← Back to issue list

fix(yaml): correctly add default parts

View original Github issue

Metadata

Project
charmcraft
Number
#1815
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1815 (commit 2a0eb973) fixed YAML default-part handling broken by the Pydantic 2 migration, unblocking Pydantic 2 merge to main via #1817.

Resolution: closed resolved

Reason: The PR itself was merged to main as commit 2a0eb973 after approval from two reviewers, correcting the malformed default-parts injection introduced by the Pydantic 2 work in #1777. It also fixed the reported regression in issue #1812 (base charms missing charm source).

Evaluated by: mr-cal-bot

No scores available.

Issue body

The pydantic 2 change caused some weirdness in adding default parts, so this fixes it. After this, pydantic 2 should be ready to merge to main.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1815 (commit 2a0eb973) fixed YAML default-part handling broken by the Pydantic 2 migration, unblocking Pydantic 2 merge to main via #1817.
stealth/space-bunny-alpha — closed resolved Merged PR #1815 (commit 2a0eb973) fixed YAML default-part handling broken by Pydantic 2, unblocking its merge to main.
qwen/qwen3.6-35b-a3b — — Merged after fixing YAML default part handling broken by Pydantic 2. Approved by two reviewers, the change updates 14 files (+61/-81 lines) to correctly apply defaults, unblocking the Pydantic 2 migration.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for default part handling broken by pydantic 2 updates. The change resolves the issue and unblocks the pydantic 2 migration to main.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1777 (confidence 85%)

    feat(deps)!: switch to pydantic 2 (commit 70078b03), the change that introduced the default-parts weirdness this PR corrects.

  • Related To: canonical/charmcraft#1817 (confidence 85%)

    chore: merge pydantic 2 support to main (commit 394e6e55), unblocked by this fix.

  • Likely Fixed By: canonical/charmcraft#1812 (confidence 80%)

    Pydantic 2 regression where charms did not always include charm source; fixed by correct default-parts handling in #1815.

Related issues

Issue Project State Summary Similarity
#841 Incorrect extra set on pydantic-yaml craft-parts closed Fixed by merged PR #811 (commit 1debce16), which removed the unnecessary pydantic-yaml dependency and its nonexistent pyyaml extra.
73%