chore: merge pydantic 2 support to main
Metadata
Current evaluation
Pydantic 2 support was merged into main by PR #1817 (commit 394e6e55), completing the migration begun in #1777 across 52 files.
Resolution: closed resolved
Reason: PR #1817 was approved by two reviewers and merged into main as commit 394e6e55. It brought the reviewed Pydantic 2 support branch onto main following the dependency switch in #1777.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Everything here has already been reviewed.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Pydantic 2 support was merged into main by PR #1817 (commit 394e6e55), completing the migration begun in #1777 across 52 files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main in canonical/charmcraft#1817, adding Pydantic 2 support and typing fixes across 52 files (+2860/-714). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged Pydantic 2 support into main with typing fixes and breaking changes. Approved by two reviewers; 52 files changed (+2860/-714). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged the Pydantic 2 feature branch into main, updating the codebase and fixing typing issues. Approved by two reviewers with CI passing; the merge includes breaking changes for the Pydantic 2 upgrade. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pydantic 2 support into the main branch after approval from two reviewers. The update modifies 52 files, adding 2860 lines and removing 714, completing the dependency upgrade. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged pydantic 2 support into the main branch. The maintainer confirmed all changes were previously reviewed, and the pull request was successfully integrated without additional comments or revisions. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#1777
(confidence 100%)
Merged PR that switched Charmcraft's dependency to Pydantic 2 before #1817 integrated the support branch.
-
Related To:
canonical/charmcraft#1768
(confidence 98%)
Tracking issue for Charmcraft's Pydantic 2 migration.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #408 chore!: merge pydantic 2 feature branch to main | craft-application | merged | Merged into main via c3aae96c, making Pydantic 2 required and incorporating final typing fixes from 25ea79c; the change is explicitly breaking. | |
| #771 chore: lift-and-shift update to pydantic 2 | craft-parts | merged | Merged PR #771 as commit 6b155294, completing phase 1 of the Pydantic 2 migration across 38 files using bump-pydantic and follow-up fixes. | |
| #112 chore(deps): update to pydantic 2 & bump-pydantic | craft-archives | closed | Closed unmerged; its Pydantic 2 migration was superseded by #103 (b69f44a) and merged into main through #123. | |
| #1807 chore: merge main to pydantic feature branch | charmcraft | closed | Closed unmerged after 771 days of inactivity. The Pydantic 2 branch-sync work later reached main through #1817 at commit 394e6e55. | |
| #616 chore!: merge 2.0 feature branch to main | craft-providers | merged | Merged the 2.0 feature branch into main via PR #616 (commit b0b7a3e), removing deprecated APIs and requiring Python 3.10+ and pydantic 2. | |
| #778 chore: pydantic 2 related cleanup | craft-parts | merged | Merged Pydantic 2 cleanup across seven files in commit 68d61fa0, following prerequisite plugin-model restructuring in #775. | |
| #1351 chore(deps): update dependency pydantic to v2 | charmcraft | closed | Renovate PR bumping pydantic 1.10.13 -> 2.4.2 was closed unmerged by lengau ("will need its own project"). The upgrade later landed via PR #1777 (70078b03), merged to main in #1817 (394e6e55). | |
| #36 chore!: update to pydantic 2 | craft-grammar | merged | Merged PR #36 (commit 06fc994), completing the breaking Pydantic 2 update after two approvals and manual confirmation of the author's CLA employment status. | |
| #116 chore(deps): update dependency pydantic to v2 | craft-store | closed | Renovate's pydantic v2 bump PR was closed unmerged by @lengau (2023-10-22, "Pydantic 2 will need some significant changes"); the real migration landed later in merged PR #193 (commit 026b78d). | |
| #370 chore(deps): update dependency pydantic to v2 | craft-providers | closed | Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0. |