← Back to issue list

`pip check` linter

View original Github issue

Metadata

Project
charmcraft
Number
#1889
Type
issue
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Added a `pip check` linter for built charm virtualenvs via merged PR canonical/charmcraft#1951 (commit 3a094837), detecting inconsistent dependencies during Charmcraft analysis and packing.

Resolution: closed resolved

Reason: PR canonical/charmcraft#1951 was merged and implemented the requested linter in commit 3a094837, resolving the issue.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Create a linter that checks that the venv is consistent using `pip check` ### Why it needs to get done With strict dependencies, we want to give people a build-time error about missing dependencies rather than runtime.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Added a `pip check` linter for built charm virtualenvs via merged PR canonical/charmcraft#1951 (commit 3a094837), detecting inconsistent dependencies during Charmcraft analysis and packing.
stealth/space-bunny-alpha — closed resolved Resolved by merged PR canonical/charmcraft#1951 (commit 3a094837), adding a Charmcraft pip-check linter for validating the built charm virtualenv.
stealth/space-bunny-alpha — closed resolved Added a Charmcraft pip check linter via merged PR canonical/charmcraft#1951 (commit 3a094837), validating consistency of built charm virtualenv dependencies.
stealth/space-bunny-alpha — closed resolved Merged PR #1951 (commit 3a094837) added a Charmcraft linter that runs pip check on built charm virtualenvs and reports inconsistent dependencies.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation. The pip check linter request was abandoned and moved to an internal Jira ticket (CRAFT-3369) for charmcraft tracking. No code changes were merged.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The request was clarified as a Charmcraft linter and tracked via internal Jira ticket CRAFT-3369. No code changes were merged, and the feature remains deferred.
qwen/qwen3.6-35b-a3b — — Closed and abandoned. The pip check linter was deferred to internal Jira ticket CRAFT-3369 as a charmcraft feature, with no implementation or merge completed.
qwen3.6-35b-a3b-mtp-q6 — — Closed and abandoned. Scoped to charmcraft and deferred to internal Jira ticket CRAFT-3369. The pip check linter was never implemented.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1951 (confidence 100%)

    Merged PR adding the `pip check` linter for built charm virtualenvs.

Related issues

Issue Project State Summary Similarity
#1951 feat(linter): add 'pip check' linter charmcraft merged Merged PR #1951 (commit 3a094837) added the 'pip-check' Linter to charmcraft/linters.py, running pip check against the built charm's venv and warning on inconsistent environments.
84%
#1890 PYDEPS linter charmcraft closed Implemented the PYDEPS linter in charmcraft PR #2250 (commit 8877d1b1), checking that dependencies required by included charm libraries are installed in the venv.
72%