← Back to issue list

feat(linter): add 'pip check' linter

View original Github issue

Metadata

Project
charmcraft
Number
#1951
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1951 (commit 3a094837) added the 'pip-check' Linter to charmcraft/linters.py, running pip check against the built charm's venv and warning on inconsistent environments.

Resolution: closed resolved

Reason: The PR itself was the resolution: merged into main as commit 3a094837 'feat(linter): add pip check linter (#1951)', with approved review. The PipCheck linter remains in charmcraft/linters.py, documenting it in docs/reference/plugins/poetry_plugin.rst.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This linter runs 'pip check' on the venv of the resulting charm and warns if the virtual environment is inconsistent.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1951 (commit 3a094837) added the 'pip-check' Linter to charmcraft/linters.py, running pip check against the built charm's venv and warning on inconsistent environments.
stealth/space-bunny-alpha — closed resolved PR #1951 by lengau added a 'pip-check' linter that runs 'pip --python <venv>/bin/python check' on the built charm venv and warns on inconsistency. Merged as commit 3a094837.
stealth/space-bunny-alpha — closed resolved Added a Charmcraft linter that runs pip check against the built charm's venv and warns when dependencies are inconsistent. Merged in #1951 (3a094837).
qwen/qwen3.6-35b-a3b — — Merged a linter that executes pip check on the generated charm virtual environment to flag dependency inconsistencies. Approved by two reviewers, the update adds 263 lines across six files to enforce package integrity validation.
qwen3.6-35b-a3b-mtp-q6 — — Merged a linter that runs pip check on charm virtual environments to flag dependency inconsistencies. Implemented by maintainer lengau without additional review comments.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#1889 (confidence 92%)

    Original feature request issue 'pip check linter' closed by the merged PR #1951.

  • Related To: charmcraft#2250 (confidence 55%)

    Later commit 8877d1b1 added the PYDEPS linter in the same linters.py module; no replacement for PipCheck.

Related issues

Issue Project State Summary Similarity
#1889 `pip check` linter charmcraft closed Added a `pip check` linter for built charm virtualenvs via merged PR canonical/charmcraft#1951 (commit 3a094837), detecting inconsistent dependencies during Charmcraft analysis and packing.
84%