← Back to issue list

chore(cleanup): remove unused code

View original Github issue

Metadata

Project
charmcraft
Number
#1907
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged cleanup removing unused code. Deleted the cmdbase module and replaced the registry module with skopeo and the docker library. Cleaned up 1857 lines across 7 files following approval from two reviewers.

Suggested action:

No scores available.

Issue body

The cmdbase module was only being used for a constant that said "json", and the registry module has been replaced with skopeo and the docker library.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged cleanup removing unused code. Deleted the cmdbase module and replaced the registry module with skopeo and the docker library. Cleaned up 1857 lines across 7 files following approval from two reviewers.
qwen3.6-35b-a3b-mtp-q6 Merged cleanup removing the unused cmdbase module and replacing the registry module with skopeo and the docker library.
qwen3.6-35b-a3b-mtp-q6 Merged cleanup removing the unused cmdbase module and replacing the registry module with skopeo and the docker library. The cmdbase module was only needed for a json constant, which was eliminated during refactoring.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1776 chore: remove unused code charmcraft merged Merged after removing 17,571 lines of unused code across 36 files. Temporarily set to draft for additional cleanup, then approved by two reviewers and merged.
76%
#1772 chore: remove unused package module charmcraft closed Merged to remove the unused package module, deleting 2,477 lines across two files. The cleanup eliminated test-only dependencies without requiring review.
75%
#4345 chore: remove unused list_registered legacy code snapcraft merged Merged changes removing unused legacy list_registered code, eliminating final references to Price. Approved by two reviewers, passed CI, and fixes #4296. The commit modifies four files, deleting 49 lines.
72%
#6079 chore: delete unused file snapcraft merged Merged a pull request removing an unused file following a migration to a pyproject-based setup. The change was approved by two reviewers, passed all CI checks, and deleted three lines from a single file.
71%