← Back to issue list

chore(cleanup): remove unused code

View original Github issue

Metadata

Project
charmcraft
Number
#1907
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit d590c429, removing unused cmdbase code and the obsolete registry implementation after replacement by skopeo and the Docker library; net deletion: 1,847 lines.

Resolution: closed resolved

Reason: PR #1907 was approved and merged as commit d590c429. The cleanup removed the unused cmdbase module and legacy registry code.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The cmdbase module was only being used for a constant that said "json", and the registry module has been replaced with skopeo and the docker library.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit d590c429, removing unused cmdbase code and the obsolete registry implementation after replacement by skopeo and the Docker library; net deletion: 1,847 lines.
stealth/space-bunny-alpha — closed resolved Merged cleanup PR #1907 (commit d590c429) by lengau: deleted unused charmcraft/cmdbase.py and the obsolete registry module, which had been superseded by skopeo and the Docker library. Net -1,847 lines.
stealth/space-bunny-alpha — closed resolved Merged cleanup PR #1907, removing the unused cmdbase module and obsolete registry code after replacement by skopeo and the Docker library; net deletion of 1,847 lines.
qwen/qwen3.6-35b-a3b — — Merged cleanup removing unused code. Deleted the cmdbase module and replaced the registry module with skopeo and the docker library. Cleaned up 1857 lines across 7 files following approval from two reviewers.
qwen3.6-35b-a3b-mtp-q6 — — Merged cleanup removing the unused cmdbase module and replacing the registry module with skopeo and the docker library.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1776 chore: remove unused code charmcraft merged Merged PR #1776 as commit 027696be, deleting 17,571 lines of unused code across 36 files after maintainer review and approval.
78%
#1830 chore: remove unused file `bases.py` charmcraft merged Merged PR #1830 removed the unused 169-line bases.py module; commit 9a35c1ec records the cleanup.
71%
#2682 chore: delete some dead code charmcraft merged Merged PR #2682 that removes 19 lines of dead code related to the project-service cast issue fixed in #2681.
70%