← Back to issue list

chore: delete some dead code

View original Github issue

Metadata

Project
charmcraft
Number
#2682
Type
pull request
State
open
Author
bepri
Labels
—
Created
Updated
Closed
—

Current evaluation

Removes 19 lines of dead code in one file, a follow-up to #2681 (remote-build project name fix). Approved by a maintainer, CI mostly green with a few failing/pending snap tests.

Suggested action: needs review

Reason: Maintainer-authored, already approved by one reviewer with zero unresolved comments, and last activity was 1 day ago, so it is fresh and ready to land. The diff is a trivial -19 line dead-code deletion tied to the already-merged #2681 remote-build fix, with only a few non-blocking snap-test CI failures (20.04/25.10) and one pending 22.04 job.

Impact: 5 Quick Win: 4.75 Staleness: 5 Complexity: 5 Confidence: 80

Issue body

Found some code that _would've_ had the same issue that #2681 fixes, but it wasn't referenced anywhere anymore. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 5
Quick Win: 4.75
Staleness: 5
Complexity: 5
Confidence: 80
needs review Removes 19 lines of dead code in one file, a follow-up to #2681 (remote-build project name fix). Approved by a maintainer, CI mostly green with a few failing/pending snap tests.
qwen/qwen3.6-35b-a3b
Staleness: 15
Complexity: 5
Confidence: 90
needs review Removes 19 lines of unused dead code related to issue #2681. Approved by one reviewer, CI mostly passing with a few failing OS-specific tests. Awaiting final maintainer review to land.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 5
Confidence: 90
needs review Removes 19 lines of unreferenced dead code that previously shared an issue fixed in #2681. Currently awaiting maintainer review with CI passing.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 5
Confidence: 90
close stale Removes 16 lines of unreferenced dead code identified as potentially problematic like issue #2681. Currently pending maintainer review with multiple failing CI checks and no activity for 80 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 62
Complexity: 5
Confidence: 75
keep open Removes unreferenced dead code previously linked to issue #2681. PR is inactive for 66 days with no comments or CI feedback.
qwen3.6-35b-moe-q4
Staleness: 45
Complexity: 10
Confidence: 75
keep open Removes unreferenced dead code related to issue #2681. PR is currently inactive with zero comments and no visible CI status, awaiting review or merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 10
Confidence: 85
needs review Removes unreferenced dead code that previously shared an issue fixed in #2681. Open for 44 days with zero comments. Currently inactive and awaiting review or triage.

Update history

Date Change
updated
updated

Related work

  • Related To: charmcraft#2681 (confidence 90%)

    PR body states the removed code 'would've had the same issue that #2681 fixes'; #2681 (remote-build project name fix) is merged.

Related issues

Issue Project State Summary Similarity
#6010 chore!: remove remote-build service override snapcraft merged Merged cleanup removing the remote-build service override and manual spread tests. This follow-up addresses overlooked work from PR #5994. Approved by two reviewers, modifying seven files.
78%
#392 chore: remove codeowners starbase merged Merged after approval from two reviewers and passing all CI checks. The change removes the CODEOWNERS file, deleting 9 lines from a single file as discussed in standup.
77%
#2444 chore: clean up unused/unnecessary files charmcraft merged Merged a chore change removing 286 lines across 10 unused files. Approved by two reviewers and integrated despite non-blocking macOS test failures and type checker warnings.
77%
#1776 chore: remove unused code charmcraft merged Merged after removing 17,571 lines of unused code across 36 files. Temporarily set to draft for additional cleanup, then approved by two reviewers and merged.
76%
#5994 chore!: remove legacy remote builder snapcraft merged Merged changes removing the legacy remote builder, resolving issue #5676. Approved by three reviewers and passing CI checks. The update deletes 3,200 lines across 30 files to clean up deprecated build infrastructure.
75%
#5281 chore: clean up some warnings snapcraft merged Merged a cleanup commit series resolving deprecation warnings across 21 files, cutting test output from over 3000 to 700. Risky changes and upstream warnings were excluded. Approved by two reviewers and passed CI.
75%
#923 chore(merge): 2.1.4 into main craft-parts merged Merged release 2.1.4 back into the main branch. Approved by two reviewers with passing CI checks. The update modified 10 files, adding 49 lines and removing 16.
75%
#5287 chore: delete empty shellcheckrc file snapcraft merged Merged PR removing an accidentally committed empty shellcheckrc file. Approved by two reviewers and passed CI, successfully cleaning the repository root.
75%
#6079 chore: delete unused file snapcraft merged Merged a pull request removing an unused file following a migration to a pyproject-based setup. The change was approved by two reviewers, passed all CI checks, and deleted three lines from a single file.
74%
#4383 chore: rename remote-build test snapcraft merged Merged a code cleanup that renamed the test module to match the source file remote.py. Approved by two reviewers, passed CI checks, and successfully integrated into the main branch.
74%