← Back to issue list

chore: delete some dead code

View original Github issue

Metadata

Project
charmcraft
Number
#2682
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2682 that removes 19 lines of dead code related to the project-service cast issue fixed in #2681.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged, removing 19 lines of dead code that referenced the same incorrect cast fixed by #2681.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Found some code that _would've_ had the same issue that #2681 fixes, but it wasn't referenced anywhere anymore. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #2682 that removes 19 lines of dead code related to the project-service cast issue fixed in #2681.
~deepseek/deepseek-pro-latest
Impact: 20
Quick Win: 14
Complexity: 10
Confidence: 75
Actionability: 80
needs review Deletes 19 lines of dead code that had the same incorrect project-service cast fixed by #2681; approved with no unresolved comments.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 5
Complexity: 10
Confidence: 65
Actionability: 60
needs review Deletes 19 lines of unreferenced dead code that would have had the same project-name bug fixed in #2681. Approved, but CI has failing snap tests.
qwen/qwen3.6-35b-a3b
Impact: 10
Quick Win: 8
Complexity: 5
Confidence: 75
Actionability: 80
needs review Removes 19 lines of dead code from charmcraft. Approved by 1 reviewer with 0 unresolved comments. Most CI checks passing; some snap-tests failing on specific Ubuntu versions.
qwen/qwen3.8-27b
Impact: 5
Quick Win: 5
Staleness: 5
Complexity: 5
Confidence: 80
needs review Removes 19 lines of dead code in one file, a follow-up to #2681 (remote-build project name fix). Approved by a maintainer, CI mostly green with a few failing/pending snap tests.
qwen/qwen3.6-35b-a3b
Staleness: 15
Complexity: 5
Confidence: 90
needs review Removes 19 lines of unused dead code related to issue #2681. Approved by one reviewer, CI mostly passing with a few failing OS-specific tests. Awaiting final maintainer review to land.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 5
Confidence: 90
needs review Removes 19 lines of unreferenced dead code that previously shared an issue fixed in #2681. Currently awaiting maintainer review with CI passing.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 5
Confidence: 90
close stale Removes 16 lines of unreferenced dead code identified as potentially problematic like issue #2681. Currently pending maintainer review with multiple failing CI checks and no activity for 80 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 62
Complexity: 5
Confidence: 75
keep open Removes unreferenced dead code previously linked to issue #2681. PR is inactive for 66 days with no comments or CI feedback.

Update history

Date Change
merged
updated
updated
updated
updated
updated

Related work

  • Related To: canonical/charmcraft#2681 (confidence 95%)

    PR #2681 fixed the same incorrect project-service cast that this dead code would have had.

Related issues

Issue Project State Summary Similarity
#1776 chore: remove unused code charmcraft merged Merged PR #1776 as commit 027696be, deleting 17,571 lines of unused code across 36 files after maintainer review and approval.
79%
#369 chore: fix linting imagecraft merged Merged PR #369 removed two redundant casts (1 file, +2/-2), fixing Ty linting; the lint/files check passed.
75%
#5540 chore: resolve deprecation warnings snapcraft merged Merged PR #5540 as commit 93e9c9237, fixing deprecation warnings and closing #5539.
73%
#6474 chore: remove unused errors snapcraft merged Merged PR removing three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py; no behavior change.
72%
#117 chore: clean up cruft craft-actions closed Merged PR #117 as commit 37d00fc, removing 117 lines from nine files to clean repository cruft ahead of v1.
72%
#2444 chore: clean up unused/unnecessary files charmcraft merged Merged maintenance PR #2444 (commit 6b94f660) removing 286 lines across 10 unused/unnecessary files after two approvals; macOS smoke-test jobs failed but did not block the merge.
72%
#6079 chore: delete unused file snapcraft merged Merged PR #6079 as commit 75686f3da, deleting a three-line file unused since Snapcraft moved to a pyproject-based setup.
72%
#5094 chore: fix deprecation warnings snapcraft merged Merged PR #5094 in commit 0633e5a65, fixing library deprecation warnings across five files (+16/-14 lines).
71%
#2028 chore: two small non-code changes charmcraft merged Merged PR #2028 incorporated two small non-code updates across two files (+5/-2), with approval from two reviewers.
71%
#196 chore(service): refactor dispatcher loop fetch-service merged Merged PR #196 extracted the dispatcher loop into a separate function for readability, landing on main as commit dd45acd.
71%