← Back to issue list

feat(linter): add PYDEPS linter

View original Github issue

Metadata

Project
charmcraft
Number
#1971
Type
pull request
State
closed
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged and superseded by charmcraft#2250, which merged the PYDEPS linter in commit 8877d1b1 and resolved #1890.

Resolution: closed superseded

Reason: PR #1971 was closed without merging. Its same-purpose implementation landed through charmcraft#2250 in commit 8877d1b1, closing #1890.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This linter reads in all PYDEPS listed in a charm's libraries and verifies that they are installed and sufficient. Closes #1890.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by charmcraft#2250, which merged the PYDEPS linter in commit 8877d1b1 and resolved #1890.
stealth/space-bunny-alpha — closed superseded PYDEPS linter PR #1971 closed unmerged; equivalent validation was later merged in canonical/charmcraft#2250 via commit 8877d1b1.
stealth/space-bunny-alpha — closed superseded PR #1971 (bepri, +107 lines) adding a PYDEPS linter was closed unmerged after 714 days; the feature was later delivered by merged PR #2250 in commit 8877d1b1, which closed #1890.
stealth/space-bunny-alpha — closed superseded Closed unmerged; PYDEPS validation was later implemented by canonical/charmcraft#2250 in commit 8877d1b1, which resolved #1890.
qwen/qwen3.6-35b-a3b — — Merged to add a PYDEPS linter that verifies charm library dependencies are installed and sufficient, resolving issue #1890. The commit introduces 107 lines of validation logic across a single file.
qwen3.6-35b-a3b-mtp-q6 — — Merged a feature adding a PYDEPS linter to verify charm library dependencies are installed and sufficient, resolving issue #1890.

Update history

No update history recorded yet.

Related work

  • Superseded By: charmcraft#2250 (confidence 100%)

    Merged replacement PR implementing the PYDEPS linter in commit 8877d1b1.

  • Related To: charmcraft#1890 (confidence 100%)

    Tracking issue targeted by #1971 and ultimately closed by the merged #2250 implementation.

Related issues

Issue Project State Summary Similarity
#2250 feat(linters): PYDEPS linter charmcraft merged Merged PR #2250 in commit 8877d1b1, adding a linter that verifies installed packages match charmlib PYDEPS and fixes #1890.
79%
#1890 PYDEPS linter charmcraft closed Implemented the PYDEPS linter in charmcraft PR #2250 (commit 8877d1b1), checking that dependencies required by included charm libraries are installed in the venv.
79%
#1777 feat(deps)!: switch to pydantic 2 charmcraft merged Breaking PR #1777 (commit 70078b03) migrated charmcraft to pydantic 2, absorbing the #1776 unused-code cleanup; merged into main via #1817 (394e6e55) after #1815 fixed YAML default-parts.
73%