← Back to issue list

feat(linters): PYDEPS linter

View original Github issue

Metadata

Project
charmcraft
Number
#2250
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2250 in commit 8877d1b1, adding a linter that verifies installed packages match charmlib PYDEPS and fixes #1890.

Resolution: closed resolved

Reason: PR #2250 was approved and merged as commit 8877d1b1, implementing the PYDEPS linter requested by charmcraft#1890. The maintainer attributed the lone failing Google spread test to infrastructure issues.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This adds a linter that checks the PYDEPS of all charmlibs in a charm to ensure the resulting packages match. Fixes #1890 CRAFT-3370

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2250 in commit 8877d1b1, adding a linter that verifies installed packages match charmlib PYDEPS and fixes #1890.
stealth/space-bunny-alpha — closed resolved Merged PR #2250 in commit 8877d1b1, adding a linter that validates charmlib PYDEPS against resulting packages and resolving #1890.
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Added a PYDEPS linter to verify charmlib package consistency, resolving #1890 and CRAFT-3370. The author overrode a single failing spread test caused by infrastructure issues to complete the merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged after introducing a PYDEPS linter to verify charmlib package dependency consistency. Resolves #1890 and CRAFT-3370. A single CI spread test failure was attributed to infrastructure limits, prompting the maintainer to override and merge.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: charmcraft#1890 (confidence 100%)

    PR #2250 explicitly fixes the PYDEPS linter issue.

Related issues

Issue Project State Summary Similarity
#1971 feat(linter): add PYDEPS linter charmcraft closed Closed unmerged and superseded by charmcraft#2250, which merged the PYDEPS linter in commit 8877d1b1 and resolved #1890.
79%
#1890 PYDEPS linter charmcraft closed Implemented the PYDEPS linter in charmcraft PR #2250 (commit 8877d1b1), checking that dependencies required by included charm libraries are installed in the venv.
76%