← Back to issue list

Check `charmcraft.yaml` for charm name

View original Github issue

Metadata

Project
charmcraft
Number
#1974
Type
pull request
State
merged
Author
DanielArndt
Labels
Created
Updated
Closed

Current evaluation

Merged changes to validate the charm name in charmcraft.yaml, resolving issue 1973. It passed CI, received two approvals, and was merged after the author corrected a CLA email mismatch via force push.

Suggested action:

No scores available.

Issue body

I don't know if this is the best way to solve the problem, but it's an attempt to solve #1973 Tested locally and it seems to solve the problem.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes to validate the charm name in charmcraft.yaml, resolving issue 1973. It passed CI, received two approvals, and was merged after the author corrected a CLA email mismatch via force push.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds validation to verify the charm name in charmcraft.yaml, resolving issue #1973. The author force-pushed to fix commit email settings for CLA compliance. Unrelated status checks did not block the merge.
qwen3.6-35b-a3b-mtp-q6 Merged changes that validate the charm name in charmcraft.yaml, resolving issue #1973. The author force-pushed to correct CLA email mismatches before successful integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#397 feat: add charmcraft inspector fetch-service merged Merged the charmcraft inspector, verifying charmcraft.yaml existence. Approved by two reviewers, passed CI, and changed 7 files. The author addressed invocation order review comments prior to final merge.
78%
#1850 feat(metadata): add charm-user to charmcraft.yaml charmcraft merged Merged a feature adding charm-user to charmcraft.yaml, resolving issue #1806. Approved by two reviewers and passing CI, the update modifies five files with 38 additions and 2 deletions.
76%
#1149 command: charmcraft init to use charmcraft.yaml only charmcraft merged Merged after review. Updated charmcraft init to use a unified charmcraft.yaml by default, replacing separate metadata, actions, and config files. Added profile descriptions and updated URLs. Initially blocked but eventually merged.
76%
#734 improve "not a valid charm name" error charmcraft merged Merged a one-line change to improve the error message for invalid charm names. Approved by a reviewer and merged on March 30, 2022.
75%
#471 config: add charm part to documentation (CRAFT-356) charmcraft merged Merged changes adding charm configuration documentation to the configuration schema. Approved by two reviewers with zero unresolved comments. Updated two files with 15 additions and one deletion. Resolves CRAFT-356.
75%
#380 Charmcraft imported improvements starbase merged Merged minor import improvements for Charmcraft across two files. Approved by two reviewers and passed all CI checks before integration.
74%
#1468 replaced metadata.yaml with charmcraft.yaml in integration test templates charmcraft closed Abandoned due to unresolved CLA signature issues. The maintainer confirmed the template update was valid and created a new PR to apply the changes and resolve the check.
74%
#1622 fix: reorganise charmcraft.yaml preprocessing charmcraft merged Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines).
74%
#711 improve "not a valid charm name" error charmcraft merged Merged an update to the "not a valid charm name" error message. The change clarifies the required naming pattern, eliminating the need to inspect source code. Approved by one reviewer and merged with a 5-line addition and 1-line deletion.
74%
#2358 docs: release Charmraft 3.5.2 charmcraft merged Merged to publish Charmcraft 3.5.2. Changes update release notes and cherry-pick fixes from main. Approved by two reviewers and merged after passing the majority of CI checks, with a few failing tests disregarded.
73%