← Back to issue list

Check `charmcraft.yaml` for charm name

View original Github issue

Metadata

Project
charmcraft
Number
#1974
Type
pull request
State
merged
Author
DanielArndt
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1974 (commit beb5c145), fixing #1973: list-lib now reads the charm name from charmcraft.yaml instead of requiring metadata.yaml.

Resolution: closed resolved

Reason: PR #1974 was approved and merged as commit beb5c145. The change made list-lib obtain the project name from charmcraft.yaml, resolving the missing metadata.yaml failure.

Evaluated by: mr-cal-bot

No scores available.

Issue body

I don't know if this is the best way to solve the problem, but it's an attempt to solve #1973 Tested locally and it seems to solve the problem.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1974 (commit beb5c145), fixing #1973: list-lib now reads the charm name from charmcraft.yaml instead of requiring metadata.yaml.
stealth/space-bunny-alpha — closed resolved PR #1974 by DanielArndt merged (commit beb5c145), fixing #1973: `charmcraft list-lib` now reads the charm name from charmcraft.yaml instead of requiring metadata.yaml.
stealth/space-bunny-alpha — closed resolved Merged PR #1974 in commit beb5c145, fixing #1973 by making list-lib obtain the charm name from charmcraft.yaml instead of requiring metadata.yaml.
qwen/qwen3.6-35b-a3b — — Merged changes to validate the charm name in charmcraft.yaml, resolving issue 1973. It passed CI, received two approvals, and was merged after the author corrected a CLA email mismatch via force push.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds validation to verify the charm name in charmcraft.yaml, resolving issue #1973. The author force-pushed to fix commit email settings for CLA compliance. Unrelated status checks did not block the merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1973 (confidence 100%)

    PR #1974 explicitly fixed the list-lib failure reported by issue #1973.

Related issues

Issue Project State Summary Similarity
#1973 `charmcraft list-lib` does not work without a `metadata.yaml` file charmcraft closed charmcraft list-lib required metadata.yaml for the charm name. Fixed by merged PR #1974 (commit beb5c145), making list-lib read the name from charmcraft.yaml; tracked internally as CRAFT-3695.
84%
#77 Deduce the charm's name from the file's included metadata, not its name charmcraft closed Fixed in merged PR #246 (commit 6401d553): upload now derives the charm name from metadata.yaml inside the ZIP instead of the filename.
73%
#1530 Changing charmcraft.yaml doesn't update the resulting charm's metadata.yaml charmcraft open The original stale metadata.yaml bug was fixed by merged PR #2874; a later Charmcraft 5.5.0 stale-repack variant remains tracked in craft-application#821.
73%
#1149 command: charmcraft init to use charmcraft.yaml only charmcraft merged Merged in ca4df024: charmcraft init now generates a unified charmcraft.yaml containing metadata, actions, and config, with profile descriptions and an updated URL.
72%
#2498 fix: `charmcraft pack --project-dir` with metadata.yaml charmcraft closed Closed unmerged; superseded by #2644, which fixed metadata lookup for --project-dir and shipped in Charmcraft 4.2.1.
71%
#1498 docs: Fix 404 in charmcraft.yaml.j2 charmcraft closed Merged in canonical/charmcraft#1498, correcting a broken charmcraft.yaml.j2 documentation link that returned 404.
70%
#734 improve "not a valid charm name" error charmcraft merged Merged in charmcraft#734 (commit 1ac7a8c0; merge fb50a098), clarifying the required lowercase-letter, alphanumeric-and-hyphen charm naming pattern.
70%