← Back to issue list

Deduce the charm's name from the file's included metadata, not its name

View original Github issue

Metadata

Project
charmcraft
Number
#77
Type
issue
State
closed
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Fixed in merged PR #246 (commit 6401d553): upload now derives the charm name from metadata.yaml inside the ZIP instead of the filename.

Resolution: closed resolved

Reason: Merged PR #246, commit 6401d553, introduced get_name_from_zip(), which opens the archive and reads the embedded metadata.yaml name, with bundle.yaml support for bundles.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently in the upload command, if a charm binary is pointed out to upload, we deduce the charm's name from the pointed out binary name. We should open that binary (unzip it), get its included `metadata.yaml`, parse it, and get the name from there.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed in merged PR #246 (commit 6401d553): upload now derives the charm name from metadata.yaml inside the ZIP instead of the filename.
stealth/space-bunny-alpha — closed resolved Charm names are now read from metadata.yaml inside the ZIP; commit 6401d553 added archive-based name detection and analogous bundle.yaml support.
stealth/space-bunny-alpha — closed stale Request to infer upload names from embedded metadata.yaml was closed without a documented resolution; no implementing PR was identified.
qwen/qwen3.6-35b-a3b — — Closed without comments or resolution, indicating the request was abandoned or superseded. The logic to extract charm names from metadata.yaml instead of filenames was never implemented.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The feature to extract the charm name from metadata.yaml instead of the filename was abandoned due to lack of discussion.
qwen/qwen3.6-35b-a3b — — Abandoned. The suggestion to extract the charm name from metadata.yaml instead of the binary filename was closed without implementation, with no pull request or resolution provided.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation. The feature to extract charm names from embedded metadata.yaml instead of filenames was abandoned. No pull requests or resolution details were provided.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#246 (confidence 96%)

    Its merged commit introduced metadata-based ZIP name extraction used by upload.

Related issues

Issue Project State Summary Similarity
#1974 Check `charmcraft.yaml` for charm name charmcraft merged Merged PR #1974 (commit beb5c145), fixing #1973: list-lib now reads the charm name from charmcraft.yaml instead of requiring metadata.yaml.
73%