Modernize the Bash completion definition.
Metadata
Current evaluation
PR #222 modernized Charmcraft's Bash completion definition and was merged into master, with a noted lack of automated drift testing.
Resolution: closed resolved
Reason: The two-reviewer-approved PR was merged by commit ca856574, containing implementation commit a25579c8. The author noted that no test could catch future omissions from the completion definition.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The sad thing is that there's no possible to add a test that checks that we forgot to update this file after adding a new command...
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #222 modernized Charmcraft's Bash completion definition and was merged into master, with a noted lack of automated drift testing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/charmcraft#222 modernized Charmcraft's Bash completion definition in one file (+22/-4 lines), with approval from two reviewers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to modernize the Bash completion definition. Approved by two reviewers, the change modifies one file (+22/-4 lines). The author noted the inability to test for missing command additions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged modernization of the Bash completion definition. The update improves script structure and compatibility, though the author noted the lack of automated tests to verify updates when new commands are added. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2111 feat: add improved bash completion script | charmcraft | merged | Merged charmcraft#2111 in commit d5a4b704, replacing Charmcraft’s legacy Bash completion with an improved script generated through craft-cli completion tooling. | |
| #4559 bash-completion: update and improve supported completion cases | snapcraft | closed | Completion work in canonical/snapcraft#4559 was closed as stale and superseded by canonical/craft-cli#319, merged in commit 4d41d7d with generated Bash completion. | |
| #231 [EXPERIMENTAL] shell completion | craft-cli | closed | Closed unmerged after inactivity; a redesigned Bash-completion feature later landed via canonical/craft-cli#319 (4d41d7d), closing #211. | |
| #5022 Bash completion script is outdated | snapcraft | closed | Snapcraft 8.7 replaced the stale manual Bash completion with an automatically generated script tracking current commands and options in merged PR #5218 (387202653). |