← Back to issue list

feat: add improved bash completion script

View original Github issue

Metadata

Project
charmcraft
Number
#2111
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged charmcraft#2111 in commit d5a4b704, replacing Charmcraft’s legacy Bash completion with an improved script generated through craft-cli completion tooling.

Resolution: closed resolved

Reason: PR #2111 was approved and merged; commit d5a4b704 implements CRAFT-3874 by adding the improved Bash completion script and removing the old one.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Adds an improved bash completion script and removes the old one. CRAFT-3874.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2111 in commit d5a4b704, replacing Charmcraft’s legacy Bash completion with an improved script generated through craft-cli completion tooling.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2111, adding an improved bash completion script and removing the legacy version.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#2111, replacing the legacy bash completion script with an improved version (+34/-195 across 6 files) for CRAFT-3874.
qwen/qwen3.6-35b-a3b — — Merged an improved bash completion script replacing the legacy version. Approved by two reviewers, the update adds 34 lines and removes 195 across six files. Resolves CRAFT-3874.
qwen3.6-35b-a3b-mtp-q6 — — Merged an improved bash completion script that replaces the legacy version, resolving CRAFT-3874. The maintainer's update was integrated directly into the codebase without additional review comments.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2151 (confidence 95%)

    Follow-up PR corrected the Bash completion build path on non-amd64 platforms.

Related issues

Issue Project State Summary Similarity
#86 feat: add bash completion script imagecraft merged Merged into main as f568b9a, adding Bash completion generation for imagecraft via craft-cli; CRAFT-3878.
81%
#319 feat: bash auto-completion generation craft-cli merged Merged feature adding generated Bash auto-completion; it closes canonical/craft-cli#211 via commit 4d41d7d.
80%
#5218 feat: add improved bash completion script snapcraft merged Merged in #5218 (commit 387202653), replacing the manually maintained Bash completion with a dynamically generated script that tracks current commands and options; shipped in Snapcraft 8.7.
79%
#222 Modernize the Bash completion definition. charmcraft merged PR #222 modernized Charmcraft's Bash completion definition and was merged into master, with a noted lack of automated drift testing.
78%
#793 feat: add improved bash completion script rockcraft merged Merged PR #793 as commit 380dd3c1, adding improved Bash tab completion for commands and options; documented in the Rockcraft 1.8 release notes.
77%
#211 Generate bash completion for the application craft-cli closed Bash completion generation was implemented and released in craft-cli 2.14.0 by merged PR canonical/craft-cli#319 (commit 4d41d7d).
74%
#453 Add in bash completion snapcraft merged Merged PR #453 via commit 6ea95fd50, adding a simple Bash completion script for Snapcraft commands.
72%
#46 New functionality from charmcraft (CRAFT-706). craft-cli merged Merged CRAFT-706 functionality from Charmcraft into craft-cli, including dispatcher and help-text improvements, via canonical/craft-cli#46 (4b190c5).
72%
#31 feat: charmcraft actions craft-actions merged Merged in commit 91513c1, adding charmcraft/setup to install Charmcraft and LXD and charmcraft/pack to run setup and package charms.
72%
#4559 bash-completion: update and improve supported completion cases snapcraft closed Completion work in canonical/snapcraft#4559 was closed as stale and superseded by canonical/craft-cli#319, merged in commit 4d41d7d with generated Bash completion.
72%