feat: add improved bash completion script
Metadata
Current evaluation
Merged an improved bash completion script replacing the legacy version. Approved by two reviewers, the update adds 34 lines and removes 195 across six files. Resolves CRAFT-3874.
Suggested action: —
No scores available.
Issue body
Adds an improved bash completion script and removes the old one.
CRAFT-3874.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged an improved bash completion script replacing the legacy version. Approved by two reviewers, the update adds 34 lines and removes 195 across six files. Resolves CRAFT-3874. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an improved bash completion script that replaces the legacy version, resolving CRAFT-3874. The maintainer's update was integrated directly into the codebase without additional review comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged an improved bash completion script replacing the legacy version, resolving CRAFT-3874. Submitted by maintainer bepri and integrated without additional review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #793 feat: add improved bash completion script | rockcraft | merged | Merged after approval by two reviewers and passing CI checks. Adds an improved bash tab-completion script, modifying four files to address CRAFT-3875. | |
| #5218 feat: add improved bash completion script | snapcraft | merged | Merged the improved bash completion script after three approvals and passing CI checks. The update modifies seven files, reducing 47 lines to 21. Reviewers validated the changes and recommended future implementation of part name autocompletion. | |
| #86 feat: add bash completion script | imagecraft | merged | Merged the bash completion script. Author rebased on main per reviewer request. Manual testing replaced automated spread tests due to complexity, with a known limitation tracked separately. | |
| #1390 meta: bash completion support | snapcraft | merged | Merged after adding bash completion support for snapcraft. Approved by two reviewers with passing CI checks. The change modifies five files, adding 72 lines and removing 2. | |
| #453 Add in bash completion | snapcraft | merged | Merged bash completion feature. Author addressed reviewer feedback by logging a related bug and updating the commit message per guidelines. After admin verification and final testing, the changes were approved and merged. | |
| #319 feat: bash auto-completion generation | craft-cli | merged | Merged the bash auto-completion generation feature. Approved by two reviewers, passed CI and tox, and closed issue #211. The change adds approximately 758 lines across 15 files to implement automatic shell completion generation. | |
| #222 Modernize the Bash completion definition. | charmcraft | merged | Merged updates to modernize the Bash completion definition. Approved by two reviewers, the change modifies one file (+22/-4 lines). The author noted the inability to test for missing command additions. | |
| #5022 Bash completion script is outdated | snapcraft | closed | Resolved in snapcraft 8.7. The outdated bash completion script was replaced with a drastically improved, automatically generated version. The long-term fix was implemented via the craft-cli integration. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. | |
| #4559 bash-completion: update and improve supported completion cases | snapcraft | closed | Closed as stale. The bash-completion script will be superseded by @bepri's solution in canonical/craft-cli#319. |