← Back to issue list

Removed forgotten URLs constants (that come from config now).

View original Github issue

Metadata

Project
charmcraft
Number
#234
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/charmcraft#234 via commit 0f4604ed, removing obsolete URL constants now supplied by configuration.

Resolution: closed resolved

Reason: PR #234 was merged through merge commit 098976e8. Commit 0f4604ed removed five obsolete URL constants because their values now come from configuration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#234 via commit 0f4604ed, removing obsolete URL constants now supplied by configuration.
stealth/space-bunny-alpha — closed resolved Removed obsolete URL constants now supplied by configuration and merged into charmcraft via PR #234, commit 0f4604ed.
stealth/space-bunny-alpha — closed resolved Merged PR #234 removed five obsolete URL constants now supplied by configuration, via commit 0f4604ed (merge 098976e8).
qwen/qwen3.6-35b-a3b — — Merged pull request removing forgotten URL constants now handled by configuration. Approved by two reviewers, passed CI checks, and deleted five lines from one file.
qwen3.6-35b-a3b-mtp-q6 — — Removed forgotten URL constants now sourced from configuration. The change was merged by a maintainer to eliminate hardcoded values and streamline the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2659 docs: remove charmhub config charmcraft merged PR #2659 (external contributor canon-cat) merged into main as commit 0e45762b, deleting 39 lines of charmhub config docs while keeping the deprecated code for backward compatibility; closes #1787.
71%
#697 Updated dependencies. charmcraft merged Merged dependency updates from canonical/charmcraft#697 into main via caa98041 (change commit 19eb9589).
70%