← Back to issue list

docs: remove charmhub config

View original Github issue

Metadata

Project
charmcraft
Number
#2659
Type
pull request
State
merged
Author
canon-cat
Labels
—
Created
Updated
Closed

Current evaluation

PR #2659 (external contributor canon-cat) merged into main as commit 0e45762b, deleting 39 lines of charmhub config docs while keeping the deprecated code for backward compatibility; closes #1787.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged as commit 0e45762b, removing the charmhub config section from the reference docs; charmcraft/models/project.py:214 still marks the field '(DEPRECATED)'. Issue #1787 was closed by this merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Remove `charmhub` references from the docs, leaving the code in place for now to keep it backward compatible. Closes #1787. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2659 (external contributor canon-cat) merged into main as commit 0e45762b, deleting 39 lines of charmhub config docs while keeping the deprecated code for backward compatibility; closes #1787.
stealth/space-bunny-alpha — closed resolved PR #2659 was merged as commit 0e45762b, removing charmhub configuration from the documentation while retaining code for backward compatibility and closing #1787.
qwen/qwen3.6-35b-a3b — — Merged into main. Documentation references to charmhub were removed while keeping the underlying code intact for backward compatibility. Closes issue 1787 after reviewer approval and CI validation.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Documentation updates removed charmhub references while preserving underlying code for backward compatibility ahead of Charmcraft 5.0. Closes #1787.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1787 (confidence 97%)

    Issue 'Remove charmhub config from charmcraft.yaml spec' was closed by this PR; the actual code removal is deferred to Charmcraft 5.0 per lengau's comment.

  • Superseded By: canonical/charmcraft#2499 (confidence 88%)

    Still-open PR that removes charmhub from the generated charmcraft.yaml schema, handling the code side of #1787.

Related issues

Issue Project State Summary Similarity
#1787 Remove charmhub config from charmcraft.yaml spec charmcraft closed Partially resolved: merged PR #2659 (0e45762b) removed charmhub from the reference; PR #2499 remains open to remove it from the generated spec.
77%
#2186 docs: fix build errors charmcraft merged Merged as charmcraft/charmcraft#2186 in commit 42f42bd2, fixing the targeted docs build error. Remaining transclusion problems were addressed separately in canonical/craft-parts#1021.
72%
#2299 docs: fix formatting issues charmcraft merged Merged docs formatting fixes for local documentation builds in charmcraft#2299 via commit 5ffb80fe; two files changed (+3/-1).
72%
#2466 build(docs): remove line length check from linter charmcraft merged Merged PR charmcraft#2466 as commit 2acf69d1, removing the documentation line-length check from the linter in a one-line configuration change.
72%
#2262 docs: hotfix for links syntax for charm docs examples charmcraft merged Merged PR #2262 as commit 675e5e7e, fixing links in the Manage charms docs and adding a Charmhub Discourse link.
72%
#234 Removed forgotten URLs constants (that come from config now). charmcraft merged Merged in canonical/charmcraft#234 via commit 0f4604ed, removing obsolete URL constants now supplied by configuration.
71%
#2745 docs: configure 4.3 docs for canonical.com proxy charmcraft merged Merged as commit 9ce27834, configuring the Charmcraft 4.3 docs for the canonical.com proxy; it supersedes the unmerged #2729 (4.2 equivalent). PR left2 unresolved review comments to replace 'oldDomain' later.
70%