← Back to issue list

chore: upgrade to craft-application 5

View original Github issue

Metadata

Project
charmcraft
Number
#2360
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main as 5e0dd360, migrating Charmcraft to craft-application 5 for CHARMCRAFT-630.

Resolution: closed resolved

Reason: PR #2360 was merged as commit 5e0dd360, completing the craft-application 5 migration. The maintainer noted that remaining failing spread tests were already failing on main.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Migrates charmcraft to craft-application 5 CHARMCRAFT-630

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main as 5e0dd360, migrating Charmcraft to craft-application 5 for CHARMCRAFT-630.
stealth/space-bunny-alpha — closed resolved Merged PR #2360, migrating Charmcraft to craft-application 5, in commit 5e0dd360; remaining spread-test failures already affected main.
stealth/space-bunny-alpha — closed resolved Merged PR #2360, upgrading Charmcraft to craft-application 5 in commit 5e0dd360. The maintainer accepted failing spread tests that were already failing on main.
qwen/qwen3.6-35b-a3b — — Merged the upgrade to craft-application 5. Approved by four reviewers, the maintainer proceeded with the merge despite failing CI tests, confirming they were pre-existing failures on main unrelated to this change.
qwen3.6-35b-a3b-mtp-q6 — — Merged upgrade to craft-application 5. Proceeded despite failing spread tests, as they were already failing on main. Resolves CHARMCRAFT-630.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5644 chore: upgrade to craft-application 5.6 snapcraft merged Merged in commit e2563a1cf: upgraded craft-application to 5.6 and moved core22 architecture detection from the project model to the project service.
87%
#1729 chore: update to craft-application 3 charmcraft merged Merged PR #1729 as commit 8f64d66a, upgrading Charmcraft to craft-application 3 and adapting the codebase to the major-version changes.
83%
#1327 chore(deps): update craft-application charmcraft merged Merged charmcraft#1327, updating craft-application across three files (+11/−9) after approval by two reviewers.
81%
#2047 chore: remove deprecated craft-application calls charmcraft closed Closed unmerged; its deprecated craft-application API cleanup was superseded by #2360, merged as 5e0dd360 in the broader craft-application 5 upgrade.
80%
#916 chore: merge 5.10.2 to main craft-application merged Merged craft-application 5.10.2 into main via commit 71051ecb, with all CI checks passing.
78%
#1465 chore(deps): update dependency craft-application to 1.2.1 charmcraft merged Merged charmcraft#1465 via commit f88283ed, updating craft-application to version 1.2.1 in two files.
78%
#1356 chore: merge main into craft-application branch charmcraft merged Merged #1356 into the craft-application branch, synchronizing main across 13 files (+82/-74); the broader migration continued in #1399 (3ba803d1).
77%
#1661 chore(deps): update dependency craft-application to v2.5.0 charmcraft merged Renovate PR #1661 was merged (commit 738a3ffe), bumping craft-application from ==2.4.0 to ==2.5.0 in two dependency files. Approved by 2 reviewers and auto-merged.
75%
#781 chore(merge): 5.2.1 into main craft-application merged Merged release 5.2.1 into main via canonical/craft-application#781 (commit b309794f), including forwarding of managed-instance parallel build settings.
75%
#4738 chore(deps): update dependency craft-application to v2.5.0 snapcraft merged Merged into main via commit 49ae242d9, upgrading craft-application from 2.4.0 to 2.5.0 with fixes needed for Snapcraft 8.2.0.
75%