← Back to issue list

chore: upgrade to craft-application 5

View original Github issue

Metadata

Project
charmcraft
Number
#2360
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged the upgrade to craft-application 5. Approved by four reviewers, the maintainer proceeded with the merge despite failing CI tests, confirming they were pre-existing failures on main unrelated to this change.

Suggested action:

No scores available.

Issue body

Migrates charmcraft to craft-application 5 CHARMCRAFT-630

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the upgrade to craft-application 5. Approved by four reviewers, the maintainer proceeded with the merge despite failing CI tests, confirming they were pre-existing failures on main unrelated to this change.
qwen3.6-35b-a3b-mtp-q6 Merged upgrade to craft-application 5. Proceeded despite failing spread tests, as they were already failing on main. Resolves CHARMCRAFT-630.
qwen3.6-35b-a3b-mtp-q6 Upgraded charmcraft to craft-application 5. Merged by the maintainer despite failing spread tests, which were already failing on main.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5644 chore: upgrade to craft-application 5.6 snapcraft merged Merged upgrade to craft-application 5.6, relocating core22 architecture detection from the project model to the project service. One integration test failed due to an external craft-application bug, but the change was approved and merged.
87%
#4585 chore: merge main into feature/craft-application snapcraft merged Merged into feature/craft-application after passing CI and receiving two approvals. The maintenance update modified 17 files (+345/-93 lines) with full test coverage for all changed code.
81%
#1729 chore: update to craft-application 3 charmcraft merged Merged after approval by two reviewers. Updated project dependencies to craft-application version 3 across 16 files, with 132 additions and 40 deletions.
81%
#1356 chore: merge main into craft-application branch charmcraft merged Merged a maintenance commit integrating the main branch into craft-application. The update modified 13 files with 82 additions and 74 deletions. No reviews or comments were required.
79%
#4633 chore: merge main into feature/craft-application snapcraft merged Merged into feature/craft-application after three approvals and passing CI. Updated 23 files with full test coverage on changed lines, maintaining 89.14% project coverage.
79%
#1397 chore: merge main to craft-application feature branch charmcraft merged Merged main into the craft-application feature branch after two approvals. The change updated 115 files and applied a manual dependency version bump to craft-application 1.1.0.
79%
#4654 chore: merge feature/components into feature/craft-application snapcraft merged Merged feature/components into feature/craft-application following three reviewer approvals. The update modified 28 files with over 1500 additions and 68 deletions. Test and CI issues were resolved during review before final integration.
78%
#463 chore(deps): update internal packages rockcraft merged Merged automated dependency updates for craft-application, craft-cli, and craft-providers. Approved by two reviewers, passed CI checks, and integrated into main. Changes apply minor version bumps and internal fixes.
78%
#856 refactor: use craft-application 5 rockcraft merged Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed.
78%
#506 chore: update to the latest craft-application rockcraft closed PR updated craft-application to latest version but was closed due to failing tests requiring additional changes. Author left for the week, and reviewer offered to take over after craft-app 2.0 tag.
78%