chore: remove deprecated craft-application calls
Metadata
Current evaluation
Closed unmerged; its deprecated craft-application API cleanup was superseded by #2360, merged as 5e0dd360 in the broader craft-application 5 upgrade.
Resolution: closed superseded
Reason: PR #2047 was closed without merging. PR #2360 later merged the broader craft-application 5 migration as commit 5e0dd360, replacing the proposed cleanup.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Switch to registering services rather than getattr-based services
- replace set_kwargs with update_kwargs
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; its deprecated craft-application API cleanup was superseded by #2360, merged as 5e0dd360 in the broader craft-application 5 upgrade. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged; the proposed craft-application API cleanup was never reviewed or tested. PR #2360 later merged the broader upgrade to craft-application 5 in 5e0dd360. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The pull request proposed removing deprecated craft-application calls by switching to service registration and replacing set_kwargs with update_kwargs across 25 files. Lacked reviewer engagement and CI checks, resulting in no action. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to remove deprecated craft-application calls. Replaced getattr-based service registration with explicit registration and replaced set_kwargs with update_kwargs. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/charmcraft#2360
(confidence 97%)
Merged as 5e0dd360 and included the craft-application API migration and deprecated-call cleanup.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2360 chore: upgrade to craft-application 5 | charmcraft | merged | Merged into main as 5e0dd360, migrating Charmcraft to craft-application 5 for CHARMCRAFT-630. | |
| #5644 chore: upgrade to craft-application 5.6 | snapcraft | merged | Merged in commit e2563a1cf: upgraded craft-application to 5.6 and moved core22 architecture detection from the project model to the project service. | |
| #1356 chore: merge main into craft-application branch | charmcraft | merged | Merged #1356 into the craft-application branch, synchronizing main across 13 files (+82/-74); the broader migration continued in #1399 (3ba803d1). | |
| #506 chore: update to the latest craft-application | rockcraft | closed | Closed unmerged after craft-application 2.0's required build_plan argument broke test helpers; the draft went inactive. A later port landed in commit de242431. | |
| #1538 chore: replace most lifecycle commands with upstream ones | charmcraft | merged | Merged as commit 5e3b927c, replacing most lifecycle commands with craft-application upstream commands; pack extension remained outstanding. | |
| #470 chore: merge 4.2.2 to main | craft-application | closed | Closed unmerged and superseded by canonical/craft-application#471, which merged version 4.2.2 into main in commit 8ac3f3dc. | |
| #1669 chore(deps): update dependency craft-application to v2.7.0 | charmcraft | merged | Merged PR #1669, upgrading craft-application from 2.6.3 to 2.7.0 in commit 3f9a94e6. | |
| #1661 chore(deps): update dependency craft-application to v2.5.0 | charmcraft | merged | Renovate PR #1661 was merged (commit 738a3ffe), bumping craft-application from ==2.4.0 to ==2.5.0 in two dependency files. Approved by 2 reviewers and auto-merged. | |
| #4738 chore(deps): update dependency craft-application to v2.5.0 | snapcraft | merged | Merged into main via commit 49ae242d9, upgrading craft-application from 2.4.0 to 2.5.0 with fixes needed for Snapcraft 8.2.0. | |
| #2371 build(deps): update dependency craft-application to v5 (main) - autoclosed | charmcraft | closed | Renovate PR #2371 (craft-application ~=4.8 -> ~=5.5) was closed unmerged and autoclosed; maintainer @upils noted it was superseded by the hand-written #2360, merged in commit 5e0dd360. |