chore: remove deprecated craft-application calls
Metadata
Current evaluation
Closed without merging. The pull request proposed removing deprecated craft-application calls by switching to service registration and replacing set_kwargs with update_kwargs across 25 files. Lacked reviewer engagement and CI checks, resulting in no action.
Suggested action: —
No scores available.
Issue body
- Switch to registering services rather than getattr-based services
- replace set_kwargs with update_kwargs
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The pull request proposed removing deprecated craft-application calls by switching to service registration and replacing set_kwargs with update_kwargs across 25 files. Lacked reviewer engagement and CI checks, resulting in no action. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to remove deprecated craft-application calls. Replaced getattr-based service registration with explicit registration and replaced set_kwargs with update_kwargs. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to remove deprecated craft-application calls, switching to service registration and replacing set_kwargs with update_kwargs. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1078 chore!: remove deprecated APIs | craft-application | merged | Merged, removing 8 deprecated APIs from craft-applications to resolve issue #1063. Approved by two reviewers with all CI checks passing. Locally verified with snapcraft, reducing code by 345 lines across 11 files. | |
| #5641 chore: test craft-providers change | snapcraft | closed | Closed without merging due to inactivity. The PR added tests for a craft-providers change but received no reviews or comments. CI passed all checks except one integration test. The contribution was abandoned. | |
| #699 chore: test craft-cli changes | rockcraft | closed | Closed without merging. The temporary test for upstream craft-cli changes received no reviews, CI checks, or comments. Likely abandoned due to inactivity shortly after creation. | |
| #1765 chore: remove classic entrypoint | charmcraft | merged | Merged after approval by two reviewers. Removed a leftover classic entrypoint from the craft-application changeover, modifying seven files. | |
| #506 chore: update to the latest craft-application | rockcraft | closed | PR updated craft-application to latest version but was closed due to failing tests requiring additional changes. Author left for the week, and reviewer offered to take over after craft-app 2.0 tag. | |
| #1075 chore!: remove Application.run_managed | craft-application | closed | Closed without merging due to unresolved review comments and failing CI tests. The author abandoned the PR to submit a fresh one. |