← Back to issue list

build(snap): enable internal plugins

View original Github issue

Metadata

Project
charmcraft
Number
#2418
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in charmcraft#2418 via commit 4960244c, enabling internal Snapcraft plugins so relevant craft-application plugins can be used.

Resolution: closed resolved

Reason: PR #2418 was approved with no unresolved comments and merged as commit 4960244c. The change enables internal plugins in the snap build.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This enables the use of internal craft-application plugins when relevant. See also: https://github.com/canonical/rockcraft/pull/822 CHARMCRAFT-640 Builds on top of https://github.com/canonical/charmcraft/pull/2412 The following test failures are unrelated: - tests/spread/smoketests/different-dir - tests/spread/smoketests/reactive:stable - tests/spread/smoketests/reactive:two

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#2418 via commit 4960244c, enabling internal Snapcraft plugins so relevant craft-application plugins can be used.
stealth/space-bunny-alpha — closed resolved Merged PR #2418 as commit 4960244c, enabling internal craft-application plugins for Charmcraft snap builds.
stealth/space-bunny-alpha — closed resolved Merged PR #2418 as commit 4960244c, enabling internal craft-application plugins in Charmcraft snap builds.
qwen/qwen3.6-35b-a3b — — Merged to enable internal craft-application plugins for snap builds. The change adds plugin support, builds on a related charmcraft PR, and passed CI checks despite unrelated test failures.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable internal craft-application plugins for snap builds. The change builds on related PRs and proceeds despite unrelated test failures and a non-blocking type checking notification.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#4672 Enable Snapcraft plugins in craft-application codepath snapcraft merged Merged PR #4672 (commit 06c842e0b), registering Snapcraft plugins in the craft-application/core24 path and exposing confinement and base lifecycle variables.
73%
#891 (internal) Install snap via craft-providers API (CRAFT-1277) charmcraft merged Merged PR #891 as commit 456601ff, switching Charmcraft snap installation to the craft-providers API and completing CRAFT-1277.
70%
#2465 fix(snap): workaround for snapcraft/craft-application bug charmcraft merged Merged charmcraft#2465, adding a three-line Snap build workaround for the craft-application bug tracked in snapcraft#5831; it was the only change for 4.0.1.
70%