← Back to issue list

fix(snap): workaround for snapcraft/craft-application bug

View original Github issue

Metadata

Project
charmcraft
Number
#2465
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged charmcraft#2465, adding a three-line Snap build workaround for the craft-application bug tracked in snapcraft#5831; it was the only change for 4.0.1.

Resolution: closed resolved

Reason: PR charmcraft#2465 was approved and merged with a one-file, +3-line workaround. It bypasses the upstream dirty-git detection problem documented in canonical/snapcraft#5831.

Evaluated by: mr-cal-bot

No scores available.

Issue body

See: https://github.com/canonical/snapcraft/issues/5831 Since this is the only change for 4.0.1 I'm not adding it to the changelog.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2465, adding a three-line Snap build workaround for the craft-application bug tracked in snapcraft#5831; it was the only change for 4.0.1.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2465, adding a three-line Snap workaround for the craft-application bug in snapcraft#5831 as the only change in 4.0.1.
qwen/qwen3.6-35b-a3b — — Merged a three-line workaround for a snapcraft/craft-application bug. Approved by two reviewers and included in the 4.0.1 release. Non-blocking type-checking warnings were noted but did not prevent integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged a workaround for a snapcraft/craft-application bug (#5831). Included in the 4.0.1 release without a changelog entry. Non-blocking type checking warnings did not prevent the merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5831 (confidence 99%)

    The PR explicitly cites this upstream issue, where git describe during an override-build incorrectly reports the repository as dirty.

Related issues

Issue Project State Summary Similarity
#58 changes to snapcraft.yaml, and version, for 0.2.0 charmcraft merged Merged PR #58 in commit 1b9913d9, updating snap/snapcraft.yaml and bumping Charmcraft to version 0.2.0.
74%
#204 Update snapcraft.yaml charmcraft merged Merged charmcraft PR #204 in commit 463e2c64, updating snap/snapcraft.yaml text for snapcraft.io and Snap users.
72%
#4659 fix: update to craft-application latest snapcraft merged Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating work from #4616, #4643, and #4651.
72%
#1950 fix: make charmcraft work with snap parallel installs charmcraft merged Merged PR #1950 via commit 2399ddf8, fixing Charmcraft conflicts during parallel snap installs and adding spread regression coverage for issue #1770.
72%
#4266 Charmcraft no longer builds from scratch using edge release of snapcraft snapcraft closed Closed as stale without a Snapcraft fix; Charmcraft PR #1146 proposed a workaround but was closed unmerged because it broke stable Snapcraft.
70%
#1770 charmcraft snap doesn't work with snap parallel installs charmcraft closed Fixed by merged PR canonical/charmcraft#1950 (commit 2399ddf8), which enabled Charmcraft to work with parallel-installed snaps and added regression coverage.
70%
#2418 build(snap): enable internal plugins charmcraft merged Merged in charmcraft#2418 via commit 4960244c, enabling internal Snapcraft plugins so relevant craft-application plugins can be used.
70%