← Back to issue list

ci: check charms generated by `charmcraft init`

View original Github issue

Metadata

Project
charmcraft
Number
#2436
Type
pull request
State
merged
Author
dwilding
Labels
Created
Updated
Closed

Current evaluation

Merged a dedicated CI spread test validating linting and unit tests for charms generated by charmcraft init across kubernetes and machine profiles. Approved by two reviewers, passes CI checks, and adds 25 lines of test configuration.

Suggested action:

No scores available.

Issue body

This PR adds a spread test that checks the charms produced by `charmcraft init --profile=kubernetes` and `charmcraft init --profile=machine`. We expect both charms to pass linting and unit tests. This is actually already covered by one of the existing spread tests - [smoketests/full-lifecycle](https://github.com/canonical/charmcraft/blob/main/tests/spread/smoketests/full-lifecycle/task.yaml) - but in discussion with Alex we decided to add a dedicated test.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a dedicated CI spread test validating linting and unit tests for charms generated by charmcraft init across kubernetes and machine profiles. Approved by two reviewers, passes CI checks, and adds 25 lines of test configuration.
qwen3.6-35b-a3b-mtp-q6 Merged a dedicated CI spread test to verify linting and unit tests for charms generated by charmcraft init across kubernetes and machine profiles, supplementing existing coverage.
qwen3.6-35b-a3b-mtp-q6 Merged a dedicated CI spread test to validate charms generated by charmcraft init for Kubernetes and machine profiles. The test ensures generated charms pass linting and unit tests, supplementing existing coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#49 ci: test the charmcraft actions in more places craft-actions merged Merged after two approvals and passing all CI checks. The update expands the continuous integration pipeline to test charmcraft actions across additional build environments, modifying a single file with minor configuration changes.
79%
#91 First pass at 'charmcraft init' charmcraft merged Merged the initial 'charmcraft init' implementation. Approved by two reviewers, the PR adds 1087 lines across 24 files to scaffold charms. README.md, additional options, and interactive prompts require future updates.
73%
#397 feat: add charmcraft inspector fetch-service merged Merged the charmcraft inspector, verifying charmcraft.yaml existence. Approved by two reviewers, passed CI, and changed 7 files. The author addressed invocation order review comments prior to final merge.
72%
#474 charmcraft: perform LXD checks before use (CRAFT-420) charmcraft merged Merged to charmcraft, adding pre-use LXD readiness and permission validation to the provider module. Consolidates existing checks, updates mocks, and improves import structure. Approved by two reviewers and passed CI.
72%
#2426 fix(test): fix the reactive charm spread test charmcraft merged Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641.
72%
#1974 Check `charmcraft.yaml` for charm name charmcraft merged Merged changes to validate the charm name in charmcraft.yaml, resolving issue 1973. It passed CI, received two approvals, and was merged after the author corrected a CLA email mismatch via force push.
72%
#2401 feat(test): add testing profiles for init command charmcraft merged Merged. Adds test-machine and test-kubernetes profiles to the init command for charmcraft test. Fixes #2365. Approved by three reviewers despite failing CI checks. Future updates will integrate jubilant and expand profiles.
72%
#143 ci: make test jobs conditional starflow merged Merged to conditionally enable CI test jobs, satisfying Charmcraft dependencies and upcoming Terraform ruleset requirements. Approved by one reviewer, passed all CI checks, and updated one file.
71%
#2031 ci: use charmcraft from the store for weekly spread runs charmcraft merged Merged a CI update that switches weekly spread runs to pull charmcraft from the store instead of building a snap. This saves build time as edge sync delays are rare. Approved by two reviewers and passed all checks.
71%
#31 feat: charmcraft actions craft-actions merged Merged changes adding two GitHub Actions: charmcraft/setup installs Charmcraft and LXD, while charmcraft/pack builds charms. Approved by two reviewers with passing CI checks, the update adds 299 lines across six files to streamline workflows.
71%