← Back to issue list

fix(test): fix the reactive charm spread test

View original Github issue

Metadata

Project
charmcraft
Number
#2426
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641.

Resolution: closed resolved

Reason: PR #2426 was approved and merged to main as commit 7c33dd1b, correcting the reactive-charm spread test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

CHARMCRAFT-641

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641.
stealth/space-bunny-alpha — closed resolved Merged a one-line fix for the reactive charm spread test in PR #2426, resolving CHARMCRAFT-641.
qwen/qwen3.6-35b-a3b — — Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the reactive charm spread test. The ty type checker flagged unresolved attributes and optional iterables as non-blocking notifications, and the changes were merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1235 tests: re-enable reactive charms test charmcraft merged Merged PR canonical/charmcraft#1235 as commit bff2a6a3, re-enabling the reactive charms test with a one-line change after two approvals.
85%
#1326 fix(test): fix reactive plugin test if 'charm' tool is installed charmcraft merged Merged test-only fix making reactive plugin tests deterministic when the charm executable is installed, via PR #1326 and commit 4a573702.
81%
#1214 tests: add more charms to large spread tests charmcraft closed Closed unmerged after 1,135 days; its large-spread test expansion landed through merged PR canonical/charmcraft#1217 in commit 0f4591a9.
77%
#2032 ci: fixes to several weekly spread tests charmcraft merged Merged PR canonical/charmcraft#2032 as commit 29cb07f3, applying a first pass of fixes to several weekly Spread tests.
77%
#1556 refactor(tests/spread): test with explicit charmcraft.yaml files charmcraft merged Merged PR #1556 in commit 4682b32b, replacing prepare-step manipulation of charmcraft.yaml with explicit spread-test configuration files.
77%
#1427 tests(spread): make dependencies restore work even if no charm is built charmcraft merged Merged in canonical/charmcraft#1427 (commit 2d432044), making spread-test dependency restoration work when no charm artifact is built.
77%
#1469 Charm upload/release spread test is flaky charmcraft closed Fixed the flaky store spread test by waiting and retrying release checks; merged in canonical/charmcraft#1460 (fd5bd6ba).
77%
#1555 refactor(tests/spread): stop use init in most spread tests charmcraft closed Closed unmerged and replaced by PR #1556, merged as commit 4682b32b, which updated Spread tests to use explicit charmcraft.yaml files instead of charmcraft init.
76%
#1287 fix(tests): fixes bundle spread test charmcraft merged Merged PR #1287 (commit f60186ce, CRAFT-2052) fixed the failing bundle spread test by validating YAML with Python and dropping a non-working charm path check, resolving #1262.
75%
#1500 test(spread): replace lunar test with mantic charmcraft merged Merged in canonical/charmcraft#1500 via commit 0fc289f4, replacing the Lunar spread test with Mantic in a one-line test update.
75%