fix(test): fix the reactive charm spread test
Metadata
Current evaluation
Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641.
Suggested action: —
No scores available.
Issue body
CHARMCRAFT-641
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the reactive charm spread test. The ty type checker flagged unresolved attributes and optional iterables as non-blocking notifications, and the changes were merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the reactive charm spread test. Type checking warnings from the ty bot were noted as non-blocking. Changes were reviewed and integrated into the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1326 fix(test): fix reactive plugin test if 'charm' tool is installed | charmcraft | merged | Merged a fix for the reactive plugin test that failed when the charm tool was installed. Approved by two reviewers with a +5/-1 line change. Resolves the test compatibility issue. | |
| #1235 tests: re-enable reactive charms test | charmcraft | merged | Merged a one-line update to re-enable the reactive charms test. Approved by two reviewers with no comments or CI issues. Successfully integrated into the repository. | |
| #1427 tests(spread): make dependencies restore work even if no charm is built | charmcraft | merged | Merged a one-line change ensuring spread test dependencies restore correctly when no charm is built. Approved by two reviewers and successfully integrated. | |
| #1287 fix(tests): fixes bundle spread test | charmcraft | merged | Merged. Resolves issue #1262 and CRAFT-2052 by fixing the bundle spread test. Replaced a failing charm path check with Python-based YAML validation. Approved by two reviewers, passed CI, and successfully executed the large spread test. | |
| #1556 refactor(tests/spread): test with explicit charmcraft.yaml files | charmcraft | merged | Merged a refactor replacing dynamic charmcraft.yaml manipulation during the prepare step with explicit configuration files. Approved by three reviewers, the change simplifies testing for upcoming variants across nine modified files. | |
| #2762 tests/spread: fix reactive spread tests on older channels | charmcraft | closed | Closed without merging due to CI failures, after proposing to remove unsupported flags from the reactive charmcraft.yaml template to fix older channel tests. | |
| #1292 test(spread): make library tests register/unregister charms | charmcraft | merged | Fixed library test failures caused by store timeouts by updating tests to register and unregister charms. Merged following approval from two reviewers, with changes spanning two files (+22/-8 lines). | |
| #2763 fix(tests/spread): fix reactive spread tests | charmcraft | merged | Merged after resolving failing reactive spread tests. The changes split the test suite into legacy and resolute variants, switched to binary wheels to fix dependency resolution, and removed obsolete flags. Approved by reviewers and integrated. | |
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions. | |
| #1198 tests: add charm library multiple versions update test | charmcraft | merged | Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments. |