← Back to issue list

test: loosen invalid charm loading test

View original Github issue

Metadata

Project
charmcraft
Number
#2490
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged a test update that ignores Pydantic version-specific URLs in exception messages. This prevents test failures during library upgrades. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

The current test depends on the exact value of the exception raised, which includes a versioned URL to the Pydantic docs. When Pydantic gets bumped, this URL changes and would require a change to all of the test strings. [Example failure here](https://github.com/canonical/charmcraft/actions/runs/19615212296/job/56166803326?pr=2485) To avoid having tests that are dependent on minor versions of libraries, this PR just avoids checking the URL in particular.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a test update that ignores Pydantic version-specific URLs in exception messages. This prevents test failures during library upgrades. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a test update to loosen invalid charm loading assertions. The change removes brittle checks on Pydantic exception URLs, preventing failures during library version bumps. Type checker warnings were logged as non-blocking notifications.
qwen3.6-35b-a3b-mtp-q6 Merged. Loosened an invalid charm loading test by removing strict matching of Pydantic's versioned URL in exception messages. This prevents test failures during library updates. Type-checking warnings were non-blocking.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1198 tests: add charm library multiple versions update test charmcraft merged Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments.
73%
#1329 test(style): remove pydocstyle tests on charmcraft code charmcraft merged Merged removal of pydocstyle tests from charmcraft code, as they are now redundant due to ruff adoption. Test functions for the init command were also relocated. Approved by two reviewers and passed CI.
71%