test(style): remove pydocstyle tests on charmcraft code
Metadata
Current evaluation
Merged removal of pydocstyle tests from charmcraft code, as they are now redundant due to ruff adoption. Test functions for the init command were also relocated. Approved by two reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
Also moves the functions only used when testing the init command to the appropriate file.
We're removing these because they're duplicated by our use of ruff.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of pydocstyle tests from charmcraft code, as they are now redundant due to ruff adoption. Test functions for the init command were also relocated. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of pydocstyle tests from charmcraft code, replaced by ruff. Test functions for the init command were also moved to their appropriate file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of pydocstyle tests from charmcraft code, replaced by ruff. Also relocated init command test functions to their proper file. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641. | |
| #188 Small text cleanups for README and charmcraft help | charmcraft | merged | Merged text cleanups for the README and charmcraft help documentation. Approved by two reviewers, the change updates 13 files to improve clarity while preserving test compatibility. | |
| #397 feat: add charmcraft inspector | fetch-service | merged | Merged the charmcraft inspector, verifying charmcraft.yaml existence. Approved by two reviewers, passed CI, and changed 7 files. The author addressed invocation order review comments prior to final merge. | |
| #1198 tests: add charm library multiple versions update test | charmcraft | merged | Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments. | |
| #1556 refactor(tests/spread): test with explicit charmcraft.yaml files | charmcraft | merged | Merged a refactor replacing dynamic charmcraft.yaml manipulation during the prepare step with explicit configuration files. Approved by three reviewers, the change simplifies testing for upcoming variants across nine modified files. | |
| #2490 test: loosen invalid charm loading test | charmcraft | merged | Merged a test update that ignores Pydantic version-specific URLs in exception messages. This prevents test failures during library upgrades. Approved by two reviewers and passed CI checks. | |
| #209 Add coverage to unit tests by default in 'charmcraft init' | charmcraft | merged | Merged. Adds default coverage reporting to unit tests generated by charmcraft init. Approved by three reviewers with passing CI. The suggestion to switch templates to tox was deferred to a separate PR. |