test(style): remove pydocstyle tests on charmcraft code
Metadata
Current evaluation
Merged in commit e7c55c88: removed redundant pydocstyle tests covered by Ruff and relocated init-command test helpers.
Resolution: closed resolved
Reason: PR #1329 was approved and merged as commit e7c55c88, eliminating duplicated pydocstyle tests and moving init-command helpers to their appropriate test file.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also moves the functions only used when testing the init command to the appropriate file.
We're removing these because they're duplicated by our use of ruff.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit e7c55c88: removed redundant pydocstyle tests covered by Ruff and relocated init-command test helpers. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #1329 merged as commit e7c55c88: deleted the pydocstyle unit tests on charmcraft code (redundant with ruff's "D" rules) and moved init-command-only test helpers into their proper test file. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1329 in commit e7c55c88, removing pydocstyle tests made redundant by Ruff and relocating init-command test helpers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of pydocstyle tests from charmcraft code, as they are now redundant due to ruff adoption. Test functions for the init command were also relocated. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of pydocstyle tests from charmcraft code, replaced by ruff. Test functions for the init command were also moved to their appropriate file. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1461 Replace flake8 and pydocstyle template tests with ruff | charmcraft | closed | Ruff replaced flake8 and pydocstyle in Charmcraft template validation via merged PR #1941 (commit 9aba24c4). | |
| #1941 fix(templates): replace flake8 and pydocstyle with ruff | charmcraft | merged | Merged PR #1941 (commit 9aba24c4) replaced flake8 and pydocstyle with Ruff in Charmcraft templates, resolving #1461. | |
| #2819 fix(tests): resolve ruff lint failures in test suite | charmcraft | merged | Merged charmcraft#2819, fixing four Ruff CI failures by making excess pytest arguments keyword-only and parenthesizing implicit string concatenations in tests. | |
| #2229 style: fix linting errors | charmcraft | merged | Merged charmcraft#2229 as commit 134e1cb6, fixing lint failures from the latest Ruff and Pyright across eight files. |