← Back to issue list

test: Platform shorthand notation and charm plugin

View original Github issue

Metadata

Project
charmcraft
Number
#2657
Type
pull request
State
merged
Author
canon-cat
Labels
Created
Updated
Closed

Current evaluation

Merged addition of tests for platform shorthand notation combined with the charm plugin, addressing regressions in earlier craft-platforms versions. Approved by two reviewers.

Suggested action:

No scores available.

Issue body

Explicitly test the combination of platform shorthand notation and charm plugin. Earlier versions of craft-platforms were breaking this combination. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged addition of tests for platform shorthand notation combined with the charm plugin, addressing regressions in earlier craft-platforms versions. Approved by two reviewers.
qwen3.6-35b-a3b-mtp-q6 Merged test coverage for platform shorthand notation combined with the charm plugin. The update prevents regressions from earlier craft-platforms versions. Passed lint and test checks prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged an external contribution adding explicit tests for platform shorthand notation combined with the charm plugin, addressing a regression in earlier craft-platforms versions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1554 feat: implement platforms for building charms charmcraft merged Merged implementation of platforms for building charms, replacing the deprecated bases field per ST105 spec. Resolves #1535 and depends on #1556 for testing. Approved by reviewers with passing CI checks.
74%
#1198 tests: add charm library multiple versions update test charmcraft merged Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments.
74%
#1660 feat: add test command and templates charmcraft merged Merged addition of the charmcraft test command and templates. The feature invokes spread to run test suites locally and remotely using a multipass backend. Approved by two reviewers and rebased on main before integration.
72%
#1287 fix(tests): fixes bundle spread test charmcraft merged Merged. Resolves issue #1262 and CRAFT-2052 by fixing the bundle spread test. Replaced a failing charm path check with Python-based YAML validation. Approved by two reviewers, passed CI, and successfully executed the large spread test.
70%
#3698 utils: platform detection logic snapcraft merged Merged into snapcraft/7.0 following reviewer approval and successful CI. The change imports platform detection logic from Charmcraft and refactors tests to use mocker. Two files modified, yielding a 1.16% test coverage increase.
70%
#1324 test(spread): test-deploy charms in large spread tests charmcraft merged Merged to add test deployment for charms and bundles in large spread tests. Approved by two reviewers, modified six files with 85 additions and 26 deletions, and linked to a passing CI run.
70%
#1326 fix(test): fix reactive plugin test if 'charm' tool is installed charmcraft merged Merged a fix for the reactive plugin test that failed when the charm tool was installed. Approved by two reviewers with a +5/-1 line change. Resolves the test compatibility issue.
70%
#2590 docs: add platform naming rules charmcraft merged Merged documentation update adding platform naming rules from craft-application. Approved by two reviewers. Integrated despite non-blocking CI test failures and type checker notifications.
70%
#2646 fix(Project): fix shorthand multi-base notation charmcraft merged Merged after updating craft-platforms to resolve shorthand multi-base notation issues in craft-application 6. Adds a test case and closes #2620 and CHARMCRAFT-691. Approved by three reviewers.
70%