← Back to issue list

fix(Project): fix shorthand multi-base notation

View original Github issue

Metadata

Project
charmcraft
Number
#2646
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 9dbd59a6, updating craft-platforms to fix craft-application 6 multi-base shorthand notation and adding regression coverage; fixes charmcraft#2620.

Resolution: closed resolved

Reason: PR #2646 merged as commit 9dbd59a6 after approval. It updated craft-platforms to correct multi-base shorthand parsing and added a regression test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This brings in a newer craft-platforms to fix the multi-base shorthand notation for craft-application 6 and adds a test case for it. Fixes: #2620 CHARMCRAFT-691 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 9dbd59a6, updating craft-platforms to fix craft-application 6 multi-base shorthand notation and adding regression coverage; fixes charmcraft#2620.
stealth/space-bunny-alpha — closed resolved Merged in #2646 as commit 9dbd59a6, fixing craft-application 6 multi-base shorthand notation via newer craft-platforms and adding a regression test.
qwen/qwen3.6-35b-a3b — — Merged after updating craft-platforms to resolve shorthand multi-base notation issues in craft-application 6. Adds a test case and closes #2620 and CHARMCRAFT-691. Approved by three reviewers.
qwen3.6-35b-a3b-mtp-q6 — — Merged an update to the craft-platforms dependency that fixes the multi-base shorthand notation for craft-application 6. Resolves #2620 and CHARMCRAFT-691 with a new test case. Type checking warnings were informational and did not block the merge.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: charmcraft#2620 (confidence 100%)

    PR #2646 explicitly fixes the shorthand-notation regression reported in issue #2620.

Related issues

Issue Project State Summary Similarity
#2620 Multi-base shorthand notation fail on v4.2.0 charmcraft closed Multi-base shorthand validation in Charmcraft 4.2.0 was fixed by merged PR #2646 (commit 9dbd59a6), which updated craft-platforms and added regression coverage.
79%
#84 fix: do not strip base from platform names craft-platforms merged Merged PR #84 via commit 7680af2: shorthand platform names now retain their base, preventing duplicate BuildInfo names required by craft-application.
75%
#81 feat: multi-base support for charm build plans craft-platforms merged Merged PR #81 as commit 519b705, adding multi-base charm build-plan support and fixing #73, with stricter shorthand validation and CraftPlatformsError.
74%
#598 feat: allow for multi-base builds craft-application merged Merged as d81c39a7; allowed bases in platform entries so applications can implement multi-base build plans, fixing #569 (CRAFT-3719).
73%
#812 feat(ProjectService): make the ProjectService compatible with multi-base craft-application merged Merged in canonical/craft-application#812 as commit c4bf6b4c, adding opt-in multi-base support and errors for unsupported apps; shipped in 5.5.0.
73%
#2069 build(deps): update craft-application and craft-providers charmcraft merged Merged in charmcraft#2069 (f65ecc0e), updating craft-application and craft-providers to isolate build environments per platform, fixing #2058 and speeding multi-base builds.
72%
#1399 feat: craft-application rebase charmcraft merged Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs.
70%