tests: add reproducer for reactive plugin missing .build.manifest (#872)

Metadata

Project: charmcraft
Number: #2664
Type: pull request
State: open
Author: lengau
Labels: —
Created: 2026-04-22 02:54 AM UTC
Updated: 2026-04-22 04:22 AM UTC
Closed: —

Current evaluation

Adds a failing unit test reproducing #872 (reactive plugin omits .build.manifest from .charm artifacts) plus a fix copying the manifest into install_dir. Pending review, 0 reviewers, CI green; branch appears stale vs main (-310 lines).

Suggested action: needs review

Reason: The work is complete (reproducer test plus fix per the Copilot comment claiming test_build_includes_build_manifest now passes) and CI is green, but it has 0 reviewers and no activity for 128 days. The +38/-310 diff stat suggests the branch is out of sync with main after reactive plugin changes like #2678, so a maintainer should review, rebase if needed, and land it; the underlying issue #872 is still open and main's _reactive.py still lacks the manifest copy.

Impact: 35 Quick Win: 28.0 Staleness: 50 Complexity: 20 Confidence: 75

Issue body

## Summary Adds a failing unit test that reproduces #872: when building a reactive charm, the `.build.manifest` file generated by `charm build` is not copied into the install directory. ## Bug When `charm build` runs, it places `.build.manifest` in the `build_dir/` root alongside the charm subdirectory. The reactive plugin only symlinks `build_dir/<charm_name>/` into `install_dir/`, so `.build.manifest` is never included in the `.charm` artifact. ## Reproducer ``` uv run python -m pytest tests/unit/parts/plugins/test_reactive.py::test_build_includes_build_manifest -v ``` The test fails with: ``` AssertionError: .build.manifest generated by charm build must be present in the install directory ``` Closes #872

Evaluation history

Date	Model	Scores	Action	Summary
2026-08-28 10:49 PM UTC	qwen/qwen3.8-27b	Impact: 35 Quick Win: 28.0 Staleness: 50 Complexity: 20 Confidence: 75	needs review	Adds a failing unit test reproducing #872 (reactive plugin omits .build.manifest from .charm artifacts) plus a fix copying the manifest into install_dir. Pending review, 0 reviewers, CI green; branch appears stale vs main (-310 lines).
2026-07-21 03:46 PM UTC	qwen3.6-35b-a3b-mtp-q6	Staleness: 65 Complexity: 20 Confidence: 60	needs review	Adds a unit test reproducing the missing .build.manifest issue in reactive plugin builds. Includes an AI-generated fix to copy the file during installation. Currently pending maintainer review after 90 days of inactivity.
2026-07-07 06:04 PM UTC	qwen3.6-35b-a3b-mtp-q6	Staleness: 75 Complexity: 20 Confidence: 60	needs review	Adds a failing unit test for issue #872 where .build.manifest is missing from the install directory. An AI-generated fix was proposed but requires maintainer validation and review.
2026-07-04 09:51 PM UTC	qwen3.6-35b-a3b-mtp-q6	Staleness: 75 Complexity: 15 Confidence: 80	close stale	Adds a failing unit test reproducing a missing .build.manifest file in the reactive plugin. Currently inactive for 73 days with no maintainer feedback or CI resolution.
2026-06-15 05:50 PM UTC	qwen3.6-35b-a3b-mtp-q6	Staleness: 55 Complexity: 15 Confidence: 80	needs review	Reactive plugin omits .build.manifest from charm install directories. Adds a reproducer test and fixes the issue by copying the file via shutil.copy2. Resolved in commit be54a55 with all tests passing.

Update history

No update history recorded yet.

Related work

Likely Fixed By: canonical/charmcraft#872 (confidence 85%)
PR body says 'Closes #872'; issue is still open and main's _reactive.py build() still lacks any .build.manifest copy, so merging this PR would fix it.

Related issues

No related issues found above the similarity threshold.