← Back to issue list

tests: add reproducer for reactive plugin missing .build.manifest (#872)

View original Github issue

Metadata

Project
charmcraft
Number
#2664
Type
pull request
State
open
Author
lengau
Labels
Created
2026-04-22 02:54:57+00:00
Updated
2026-04-22 04:22:36+00:00
Closed

Current evaluation

Includes a reproducer test and AI-generated fix for the reactive plugin failing to copy .build.manifest to the install directory, but remains inactive awaiting review.

Suggested action: needs review

Reason: The PR contains a valid test reproducer and an AI-generated fix for a reported bug but lacks maintainer review and labels. The proposed fix requires human verification to ensure it aligns with project conventions, handles edge cases, and does not introduce regressions before merging.

Staleness: 35 Complexity: 15 Confidence: 60

Issue body

## Summary Adds a failing unit test that reproduces #872: when building a reactive charm, the `.build.manifest` file generated by `charm build` is not copied into the install directory. ## Bug When `charm build` runs, it places `.build.manifest` in the `build_dir/` root alongside the charm subdirectory. The reactive plugin only symlinks `build_dir/<charm_name>/` into `install_dir/`, so `.build.manifest` is never included in the `.charm` artifact. ## Reproducer ``` uv run python -m pytest tests/unit/parts/plugins/test_reactive.py::test_build_includes_build_manifest -v ``` The test fails with: ``` AssertionError: .build.manifest generated by charm build must be present in the install directory ``` Closes #872

Evaluation history

Date Model Scores Action Summary
2026-06-15 11:51:28.030880+00:00 qwen3.6-35b-a3b-mtp-q6
Staleness: 35
Complexity: 15
Confidence: 60
needs review Includes a reproducer test and AI-generated fix for the reactive plugin failing to copy .build.manifest to the install directory, but remains inactive awaiting review.
2026-06-15 11:48:34.877671+00:00 pending