tests: add reproducer for reactive plugin missing .build.manifest (#872)
Metadata
Current evaluation
Adds failing unit test reproducing #872 and Copilot fix copying .build.manifest to install dir; 163 days old, 0 reviewers, pending review
Suggested action: needs review
Reason: Copilot added a fix in commit be54a55 that copies .build.manifest to install_dir, and the test now passes; however, the PR has 0 reviewers and is 163 days old, so it needs maintainer review before merging.
Evaluated by: mr-cal-bot
Impact:
40
Quick Win:
11
Complexity:
30
Confidence:
50
Actionability:
40
Issue body
## Summary
Adds a failing unit test that reproduces #872: when building a reactive charm, the `.build.manifest` file generated by `charm build` is not copied into the install directory.
## Bug
When `charm build` runs, it places `.build.manifest` in the `build_dir/` root alongside the charm subdirectory. The reactive plugin only symlinks `build_dir/<charm_name>/` into `install_dir/`, so `.build.manifest` is never included in the `.charm` artifact.
## Reproducer
```
uv run python -m pytest tests/unit/parts/plugins/test_reactive.py::test_build_includes_build_manifest -v
```
The test fails with:
```
AssertionError: .build.manifest generated by charm build must be present in the install directory
```
Closes #872
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest |
Impact:
40
Quick Win:
11
Complexity:
30
Confidence:
50
Actionability:
40
|
needs review | Adds failing unit test reproducing #872 and Copilot fix copying .build.manifest to install dir; 163 days old, 0 reviewers, pending review | |
| qwen/qwen3.6-35b-a3b |
Impact:
55
Quick Win:
12
Complexity:
25
Confidence:
70
Actionability:
30
|
needs review | Test reproducer for issue #872 where .build.manifest is missing from reactive charm builds; PR is open, awaiting review | |
| qwen/qwen3.8-27b |
Impact:
35
Quick Win:
28
Staleness:
50
Complexity:
20
Confidence:
75
|
needs review | Adds a failing unit test reproducing #872 (reactive plugin omits .build.manifest from .charm artifacts) plus a fix copying the manifest into install_dir. Pending review, 0 reviewers, CI green; branch appears stale vs main (-310 lines). | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
65
Complexity:
20
Confidence:
60
|
needs review | Adds a unit test reproducing the missing .build.manifest issue in reactive plugin builds. Includes an AI-generated fix to copy the file during installation. Currently pending maintainer review after 90 days of inactivity. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
75
Complexity:
20
Confidence:
60
|
needs review | Adds a failing unit test for issue #872 where .build.manifest is missing from the install directory. An AI-generated fix was proposed but requires maintainer validation and review. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
75
Complexity:
15
Confidence:
80
|
close stale | Adds a failing unit test reproducing a missing .build.manifest file in the reactive plugin. Currently inactive for 73 days with no maintainer feedback or CI resolution. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#872
(confidence 90%)
The bug this PR reproduces and fixes
-
Related To:
charmcraft#2502
(confidence 70%)
More complete fix addressing same issue #872, including charmtool-version in manifest.yaml
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2669 tests: add reproducer for pack retaining deleted files between builds (#710) | charmcraft | open | Reproducer test for #710 (pack retains deleted files) plus Copilot-generated PartsLifecycle._clean_stale_parts workaround; +112/-310, 4 files, open 163 days, 0 reviewers, snap-tests and title-policy checks failing. | |
| #2665 tests: add reproducer for upload crash outside project directory (#2492) | charmcraft | open | Adds failing unit test reproducing upload crash outside project dir (#2492); Copilot added try/except fix. Stale branch, 163 days inactive, type-check failing. | |
| #2666 tests: add reproducer for fetch-lib unhelpful error message (#2204) | charmcraft | open | Adds failing unit test reproducing #2204's 'Library None not found' error; Copilot comment claims fix in commit 4a4d0d4 but PR remains test-only and inactive 163 days. |