← Back to issue list

tests: add reproducer for fetch-lib unhelpful error message (#2204)

View original Github issue

Metadata

Project
charmcraft
Number
#2666
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds failing unit test reproducing #2204's 'Library None not found' error; Copilot comment claims fix in commit 4a4d0d4 but PR remains test-only and inactive 163 days.

Suggested action: close superseded

Reason: PR #2505 fixes the same fetch-lib error and adds test coverage, superseding this test-only reproducer. This PR has been inactive for 163 days with no human review, and the Copilot comment's claimed fix commit 4a4d0d4 is unverified on the branch.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 5 Complexity: 35 Confidence: 55 Actionability: 25

Issue body

## Summary Adds a failing unit test that reproduces #2204: `charmcraft fetch-lib` prints the unhelpful message `Library None not found in Charmhub.` when a library's `lib_id` is not registered in Charmhub. ## Bug When fetching all libs (no argument), `parsed_args.library` is `None`. When the Charmhub bulk API returns no entry for a local/unpublished library's `lib_id`, the error uses `parsed_args.library` directly, producing `"Library None not found in Charmhub."` instead of a meaningful identifier. ## Reproducer ``` uv run python -m pytest tests/unit/commands/test_store.py::test_fetch_lib_command_unregistered_lib_id_error_message -v ``` The test fails with: ``` AssertionError: Bug reproduced: error message uses 'None' instead of library name: 'Library None not found in Charmhub.' ``` Closes #2204

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest
Impact: 30
Quick Win: 5
Complexity: 35
Confidence: 55
Actionability: 25
close superseded Adds failing unit test reproducing #2204's 'Library None not found' error; Copilot comment claims fix in commit 4a4d0d4 but PR remains test-only and inactive 163 days.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 5
Complexity: 15
Confidence: 70
Actionability: 20
keep open Adds a failing unit test reproducing #2204: fetch-lib prints 'Library None not found in Charmhub.' when lib_id is unregistered. PR is inactive for 148 days; a Copilot comment claims a fix in commit 4a4d0d4 but that commit does not exist.
qwen/qwen3.8-27b
Impact: 35
Quick Win: 23
Staleness: 50
Complexity: 35
Confidence: 75
needs review Adds failing unit test reproducing #2204 (fetch-lib prints 'Library None not found in Charmhub') plus a fix using lib_data.full_name fallback. Pending review, 0 reviewers, CI passing.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 10
Confidence: 80
needs review Adds a failing unit test reproducing an unhelpful error message when fetching unregistered libraries. Author requested AI to generate a fix, but PR remains unreviewed and inactive for 90 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 15
Confidence: 80
close stale Adds a failing unit test reproducing an unhelpful error message in charmcraft fetch-lib. Inactive for 76 days with no maintainer review or CI success; author requested an AI fix that was not pushed to the PR.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 15
Confidence: 80
needs review Adds a failing unit test reproducing an unhelpful error message when fetching unregistered libraries. Author requested an AI-generated fix, but the branch remains inactive for 73 days with no maintainer review or CI confirmation.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#2204 (confidence 95%)

    This PR reproduces issue #2204, which remains open.

  • Superseded By: charmcraft#2505 (confidence 75%)

    PR #2505 fixes the same 'Library None not found' error and adds test coverage, superseding this reproducer.

Related issues

Issue Project State Summary Similarity
#2665 tests: add reproducer for upload crash outside project directory (#2492) charmcraft open Adds failing unit test reproducing upload crash outside project dir (#2492); Copilot added try/except fix. Stale branch, 163 days inactive, type-check failing.
75%
#2664 tests: add reproducer for reactive plugin missing .build.manifest (#872) charmcraft open Adds failing unit test reproducing #872 and Copilot fix copying .build.manifest to install dir; 163 days old, 0 reviewers, pending review
71%