← Back to issue list

feat(templates): add juju_setup to integration tests, improve comments, fix resolve()

View original Github issue

Metadata

Project
charmcraft
Number
#2695
Type
pull request
State
open
Author
dwilding
Labels
Created
2026-05-19 00:53:33+00:00
Updated
2026-05-20 12:43:16+00:00
Closed

Current evaluation

Updates kubernetes and machine profile integration tests by adding a juju_setup marker, improving comments, and removing a redundant resolve() call, currently awaiting review.

Suggested action: needs review

Reason: The PR is awaiting maintainer code review. It has been open for nearly a month with no labels or maintainer feedback, and the author has explicitly requested a review. It requires technical assessment and CI verification before proceeding.

Staleness: 30 Complexity: 10 Confidence: 60

Issue body

This PR bundles a few updates to the integration tests of the `kubernetes` and machine `profiles`: - Added the `@pytest.mark.juju_setup` marker from [pytest-jubilant](https://github.com/canonical/pytest-jubilant/). - Improved the comments, mainly to reduce the number of links. The best starting point for guidance about integration testing is now [How to write integration tests for a charm](https://documentation.ubuntu.com/ops/latest/howto/write-integration-tests-for-a-charm/). - Removed `resolve()` from the test that deploys the charm. We already resolve the charm path in the `charm` fixture. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
2026-06-15 11:03:44.833143+00:00 qwen3.6-35b-a3b-mtp-q6
Staleness: 30
Complexity: 10
Confidence: 60
needs review Updates kubernetes and machine profile integration tests by adding a juju_setup marker, improving comments, and removing a redundant resolve() call, currently awaiting review.
2026-06-15 11:01:15.570287+00:00 pending