feat(templates): add juju_setup to integration tests, improve comments, fix resolve()
Metadata
Current evaluation
Merged after three approvals. Adds the juju_setup marker to integration tests, improves documentation comments, and removes a redundant resolve() call in the charm deployment test. All CI checks passed prior to merge.
Suggested action: —
No scores available.
Issue body
This PR bundles a few updates to the integration tests of the `kubernetes` and machine `profiles`:
- Added the `@pytest.mark.juju_setup` marker from [pytest-jubilant](https://github.com/canonical/pytest-jubilant/).
- Improved the comments, mainly to reduce the number of links. The best starting point for guidance about integration testing is now [How to write integration tests for a charm](https://documentation.ubuntu.com/ops/latest/howto/write-integration-tests-for-a-charm/).
- Removed `resolve()` from the test that deploys the charm. We already resolve the charm path in the `charm` fixture.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after three approvals. Adds the juju_setup marker to integration tests, improves documentation comments, and removes a redundant resolve() call in the charm deployment test. All CI checks passed prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged PR adding the juju_setup pytest marker to integration tests, improving test comments, and removing a redundant resolve call in the charm deployment test. Changes were reviewed and accepted. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
35
Complexity:
20
Confidence:
85
|
needs review | Adds juju_setup marker, improves comments, and removes redundant resolve calls in kubernetes and machine profile integration tests. Currently awaiting maintainer review following a recent request for feedback. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2401 feat(test): add testing profiles for init command | charmcraft | merged | Merged. Adds test-machine and test-kubernetes profiles to the init command for charmcraft test. Fixes #2365. Approved by three reviewers despite failing CI checks. Future updates will integrate jubilant and expand profiles. | |
| #1477 fix(templates): use more explicit __init__ param types in charm templates | charmcraft | merged | Merged following two approvals and passing CI. Updated charm templates to use explicit __init__ parameter types, enhancing type safety and allowing direct framework usage in observe calls. Modified 3 files (+10/-10 lines). |