feat(templates): add juju_setup to integration tests, improve comments, fix resolve()
Metadata
Current evaluation
Merged in charmcraft PR #2695 (commit 74d12bce), adding juju_setup to generated integration tests, clarifying comments, and removing redundant resolve().
Resolution: closed resolved
Reason: PR #2695 was approved and merged into main as commit 74d12bce, implementing all three changes described in its proposal.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR bundles a few updates to the integration tests of the `kubernetes` and machine `profiles`:
- Added the `@pytest.mark.juju_setup` marker from [pytest-jubilant](https://github.com/canonical/pytest-jubilant/).
- Improved the comments, mainly to reduce the number of links. The best starting point for guidance about integration testing is now [How to write integration tests for a charm](https://documentation.ubuntu.com/ops/latest/howto/write-integration-tests-for-a-charm/).
- Removed `resolve()` from the test that deploys the charm. We already resolve the charm path in the `charm` fixture.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in charmcraft PR #2695 (commit 74d12bce), adding juju_setup to generated integration tests, clarifying comments, and removing redundant resolve(). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 74d12bce: adds @pytest.mark.juju_setup to kubernetes/machine profile integration test templates, improves comments, and drops a redundant resolve(). Noted in Charmcraft 4.3 release notes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in charmcraft PR #2695: added juju_setup to Kubernetes and machine-profile integration tests, clarified comments, and removed redundant resolve() from deployment tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after three approvals. Adds the juju_setup marker to integration tests, improves documentation comments, and removes a redundant resolve() call in the charm deployment test. All CI checks passed prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged PR adding the juju_setup pytest marker to integration tests, improving test comments, and removing a redundant resolve call in the charm deployment test. Changes were reviewed and accepted. |
Update history
| Date | Change |
|---|---|
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1540 fix: template integration tests | charmcraft | merged | Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468. | |
| #132 test: update charm integration test | craft-actions | merged | Merged in canonical/craft-actions#132 (54f7849), updating the charm pack integration test to use another simple charm after the previous Juju fixture was removed. | |
| #910 Duplicate await in integration test templates | charmcraft | closed | Fixed charmcraft init integration templates in commit 3ea45cd3 by removing the duplicate await before deployment, preventing a PosixPath TypeError. | |
| #2623 feat: update charm templates to use pytest-jubilant | charmcraft | merged | Merged PR #2623 as commit 77c4d692, updating machine and Kubernetes charm templates to use pytest-jubilant for integration tests. |