← Back to issue list

chore: add base support for Flask and Django extensions

View original Github issue

Metadata

Project
charmcraft
Number
#2756
Type
pull request
State
merged
Author
erinecon
Labels
—
Created
Updated
Closed

Current evaluation

Merged in charmcraft#2756 as commit 1d4807fe, restoring explicit Ubuntu 24.04 support for Flask and Django extensions and fixing their Spread-test failures.

Resolution: closed resolved

Reason: PR #2756 was approved and merged as commit 1d4807fe, explicitly restoring ubuntu@24.04 support for both framework extensions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add 24.04 base support for Flask and Django extensions. The current `stable` release of Charmcraft supports the `ubuntu@24.04` base for Flask and Django, which I validated by running through the tutorials manually. However, the Spread tests fail with the error `Extension ... does not support base(s): ubuntu@24.04`, indicating that some change in the `edge` release of Charmcraft has dropped support for 24.04 in Flask and Django. I'm not sure what change prompted this behavior, but this PR explicitly defines the base support in the Flask and Django frameworks, which resolves the failures in the Spread tests. This change was originally part of https://github.com/canonical/charmcraft/pull/2732 which we thought might have been fixed in a different PR ([comment thread](https://github.com/canonical/charmcraft/pull/2732#discussion_r3443178623)). However, the Spread tests failed after reverting the change in the PR (which was merged before the Spread tests finished running). * Example of failed job: https://github.com/canonical/charmcraft/actions/runs/28617084008/job/84867369161?pr=2732 * Example of failure: `Extension 'django-framework' does not support base(s): ubuntu@24.04` --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#2756 as commit 1d4807fe, restoring explicit Ubuntu 24.04 support for Flask and Django extensions and fixing their Spread-test failures.
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#2756 as 1d4807fe, restoring explicit Ubuntu 24.04 base support for Flask and Django extensions after #2732 reverted that change.
qwen/qwen3.6-35b-a3b — — Merged. Added explicit ubuntu@24.04 base support for Flask and Django extensions to resolve failing Spread tests. The contributor addressed reviewer linting feedback, received approval, and the changes were merged.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 25
Confidence: 85
needs review Adds base support for Flask and Django extensions to charmcraft. Originally part of PR #2732, which failed Spread tests after a revert. Currently awaiting review with no comments or activity.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2732 (confidence 98%)

    Its change was reverted before Spread tests completed, prompting this follow-up fix.

Related issues

Issue Project State Summary Similarity
#1578 feat(extension): support django-framework charmcraft merged Merged in canonical/charmcraft#1578, adding Django framework extension support and refactoring the Flask extension.
76%
#708 Add support for base ubuntu@24.04 to django and flask extensions rockcraft merged Merged #708 as commit e47860c9, adding Ubuntu 24.04 support to Django and Flask extensions and moving Django tests so Spread runs them.
75%
#2766 fix: support for Ubuntu 24.04 in supported bases charmcraft merged Merged PR #2766 restored Ubuntu 24.04 support for Charmcraft's Flask and Django bases by updating the supported-bases configuration.
74%
#2556 fix: charmcraft templates for flask and django extensions charmcraft merged Merged #2556 added the missing platforms key to Charmcraft YAML templates for Flask and Django 12-factor extensions.
74%
#2559 feat: update flask extension base to 24.04 charmcraft merged Merged PR #2559 as commit 15d49568, updating Charmcraft's Flask 12-factor extension base to Ubuntu 24.04.
72%
#1986 feat(extension): Add option to enable async workers in Flask and Django charmcraft merged Merged Charmcraft PR #1986 as commit 3128c623, adding a charm option to enable async Gunicorn workers for Flask and Django extensions.
71%