← Back to issue list

fix: charmcraft templates for flask and django extensions

View original Github issue

Metadata

Project
charmcraft
Number
#2556
Type
pull request
State
merged
Author
arturo-seijas
Labels
Created
Updated
Closed

Current evaluation

Merged external contribution adding the missing platforms key to charmcraft.yaml templates for Flask and Django 12-factor extensions. Approved by two reviewers, passed CI checks, and updated documentation.

Suggested action:

No scores available.

Issue body

<!-- Describe your changes --> Add missing `platforms` key in charmcraft.yaml tempaltes for flask and django 12-factor extensions --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged external contribution adding the missing platforms key to charmcraft.yaml templates for Flask and Django 12-factor extensions. Approved by two reviewers, passed CI checks, and updated documentation.
qwen3.6-35b-a3b-mtp-q6 Merged an external fix adding the missing platforms key to charmcraft.yaml templates for Flask and Django 12-factor extensions. The change resolves template configuration gaps and was accepted without review comments.
qwen3.6-35b-a3b-mtp-q6 Merged fix adding the missing platforms key to charmcraft.yaml templates for Flask and Django 12-factor extensions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1257 Add the flask extension charmcraft merged Merged an experimental Flask extension for charmcraft's Juju 12-factor charm ecosystem. Approved by two reviewers and integrated after incorporating sprint demo updates and addressing testing requirements.
78%
#1428 Add init template for flask-framework charmcraft merged Merged an external contribution adding a flask-framework profile to the charmcraft init command. The template scaffolds basic 12-factor Flask charms, omitting tests and tox.ini for standard project root placement. Approved by three reviewers.
75%
#1718 Flask extension. Allow charm-libs to be extended by the user charmcraft merged Merged. Resolves Flask extension AttributeError when charm-libs is pre-defined in charmcraft.yaml. Combines and deduplicates charm-libs from both extension and user configs. Approved and passed CI.
75%
#1620 fix: add default charm part in flask-framework charmcraft merged Merged PR adds the default charm part to the flask-framework extension and prevents conflicts with custom configurations. Template dependencies were updated to fix sdist builds, resolving issue #1616.
74%
#1578 feat(extension): support django-framework charmcraft merged Merged the django-framework extension, mirroring the flask-framework implementation. Approved by three reviewers and implemented by an external contributor across 14 files. Integrated into charmcraft.
74%
#833 Feat(12-factor): Extensions are updated to let charms use non-root users rockcraft merged Merged after review and CI completion. Updates 12-factor extensions to support non-root charm containers by fixing file permissions, adding a logging part, and setting ownership to daemon for Flask and Django extensions.
70%