← Back to issue list

ci: always discard spread workers in snap-store-tests

View original Github issue

Metadata

Project
charmcraft
Number
#2770
Type
pull request
State
closed
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Abandoned without merge. The change to add a cleanup step preventing CI VM leaks in snap-store-tests received no reviews and was closed.

Suggested action:

No scores available.

Issue body

This PR adds the 'Discard spread workers' cleanup step to the 'snap-store-tests' job in the 'spread.yaml' workflow. Without this step, if the job is cancelled or crashes, the remote Google Cloud VM instances allocated by 'spread' are not discarded, causing them to leak and run until the halt timeout (2h). Adding this step mirrors the cleanup behavior in the other jobs of the workflow.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Abandoned without merge. The change to add a cleanup step preventing CI VM leaks in snap-store-tests received no reviews and was closed.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2771 ci: always discard spread workers in snap-store-tests (main) charmcraft merged Merged CI fix adding cleanup to discard spread workers in snap-store-tests. Prevents Google Cloud VM leaks on cancellation or crash, aligning with other jobs. Approved and merged despite minor CI failures.
86%
#3089 ci: move staging store tests to spread snapcraft closed Closed without being merged. The pull request to move staging store tests to spread was abandoned, receiving no reviews, CI checks, or comments before closure.
74%
#6335 ci: always discard spread workers in manual tests (main) snapcraft merged Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file.
73%
#919 ci(experimental): add arm64 spread worker rockcraft closed Closed without merging. Failing CI checks for snap-tests, snap-tests-arm, and OSV-scanner, alongside pending review and no updates, resulted in abandonment of the arm64 spread worker addition.
73%
#2899 ci: publish the CI built snap to the Snap Store snapcraft closed CI snap publishing changes were closed without merging. Lacking reviewer feedback and with two unresolved comments, the pull request was abandoned. No CI checks executed.
72%
#115 ci: always discard spread workers in build-rock tests (core22-8) snapcraft-rocks merged Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers.
72%
#1519 ci: always discard spread runners charmcraft merged Merged a CI workflow update that permanently discards spread runners by mirroring the snapcraft repository configuration. Approved by three reviewers, the change adds 16 lines to a single workflow file.
72%
#3480 ci: spread testing snapcraft closed Closed without merging. The maintainer submitted the pull request as a temporary test, requested it be ignored, and abandoned it without review or CI checks.
71%
#1205 ci: make workflows conditional, add docs-only spread tests rockcraft closed Closed without merging. The changes to conditional CI workflows and docs-only Spread tests remained pending review with unresolved comments and failing snap-tests. The PR was likely abandoned or superseded.
71%
#482 ci: always discard spread workers rockcraft merged Merged a CI workflow update to always discard spread workers, ensuring cleanup even on workflow cancellation. This change mirrors snapcraft's spread configuration.
71%