ci: always discard spread workers in snap-store-tests (main)
Metadata
Current evaluation
Merged CI fix adding cleanup to discard spread workers in snap-store-tests. Prevents Google Cloud VM leaks on cancellation or crash, aligning with other jobs. Approved and merged despite minor CI failures.
Suggested action: —
No scores available.
Issue body
This PR adds the 'Discard spread workers' cleanup step to the 'snap-store-tests' job in the 'spread.yaml' workflow.
Without this step, if the job is cancelled or crashes, the remote Google Cloud VM instances allocated by 'spread' are not discarded, causing them to leak and run until the halt timeout (2h). Adding this step mirrors the cleanup behavior in the other jobs of the workflow.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged CI fix adding cleanup to discard spread workers in snap-store-tests. Prevents Google Cloud VM leaks on cancellation or crash, aligning with other jobs. Approved and merged despite minor CI failures. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
10
Complexity:
15
Confidence:
90
|
needs review | Adds a cleanup step to discard spread workers in the snap-store-tests job, preventing remote VM leaks on cancellation or crash. Currently awaiting review. |
Update history
| Date | Change |
|---|---|
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2770 ci: always discard spread workers in snap-store-tests | charmcraft | closed | Abandoned without merge. The change to add a cleanup step preventing CI VM leaks in snap-store-tests received no reviews and was closed. | |
| #6335 ci: always discard spread workers in manual tests (main) | snapcraft | merged | Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file. | |
| #115 ci: always discard spread workers in build-rock tests (core22-8) | snapcraft-rocks | merged | Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers. | |
| #117 ci: always discard spread workers in build-rock tests (core24-8) | snapcraft-rocks | merged | Merged changes add a cleanup step to discard spread workers in the build-rock workflow, preventing leaked Google Cloud VM instances on cancellation or crash. Resolves SNAPCRAFT-1368. | |
| #482 ci: always discard spread workers | rockcraft | merged | Merged a CI workflow update to always discard spread workers, ensuring cleanup even on workflow cancellation. This change mirrors snapcraft's spread configuration. | |
| #1519 ci: always discard spread runners | charmcraft | merged | Merged a CI workflow update that permanently discards spread runners by mirroring the snapcraft repository configuration. Approved by three reviewers, the change adds 16 lines to a single workflow file. | |
| #2333 ci: don't run spread tests when unnecessary | charmcraft | closed | Merged to optimize CI execution by skipping unnecessary spread tests and cancelling obsolete snap builds, reducing redundant pipeline runs. | |
| #2680 spread tests: minor performance improvements | snapcraft | merged | Merged minor spread test performance improvements. Changes include conditional multipass installation, --purge on snap removals, and increasing GCE workers for 16.04 to 12. Approved, passed CI, and maintained coverage. | |
| #4380 ci: download snap to tests dir | snapcraft | merged | Merged a CI fix that ensures scheduled spread tests download the snap to the tests directory. Approved by two reviewers, passed CI checks, and modified one file. | |
| #3476 ci: reduce amount of artifacts to upload for spread | snapcraft | merged | Merged a CI optimization that reduces spread upload artifacts to the tests directory, decreasing payload size. Local execution now requires copying the snap to the test directory. Approved and passed all checks. |