ci: always discard spread workers in snap-store-tests (main)
Metadata
Current evaluation
Merged PR #2771 (main) adds an always-run "Discard spread workers" cleanup step to the snap-store-tests job in spread.yaml, so cancelled/crashed CI runs no longer leak GCE VMs until the 2h halt timeout.
Resolution: closed resolved
Reason: The PR was approved and merged into main, changing spread.yaml (+8/-0, 1 file) to mirror the cleanup step already present in the workflow's other spread jobs. The change addresses the leak described in the PR description.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR adds the 'Discard spread workers' cleanup step to the 'snap-store-tests' job in the 'spread.yaml' workflow.
Without this step, if the job is cancelled or crashes, the remote Google Cloud VM instances allocated by 'spread' are not discarded, causing them to leak and run until the halt timeout (2h). Adding this step mirrors the cleanup behavior in the other jobs of the workflow.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2771 (main) adds an always-run "Discard spread workers" cleanup step to the snap-store-tests job in spread.yaml, so cancelled/crashed CI runs no longer leak GCE VMs until the 2h halt timeout. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged cleanup change in main added an always-run spread worker discard step to snap-store-tests, preventing cloud VMs from leaking when CI is cancelled or crashes. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged CI fix adding cleanup to discard spread workers in snap-store-tests. Prevents Google Cloud VM leaks on cancellation or crash, aligning with other jobs. Approved and merged despite minor CI failures. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
10
Complexity:
15
Confidence:
90
|
needs review | Adds a cleanup step to discard spread workers in the snap-store-tests job, preventing remote VM leaks on cancellation or crash. Currently awaiting review. |
Update history
| Date | Change |
|---|---|
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6335 ci: always discard spread workers in manual tests (main) | snapcraft | merged | Merged #6335 in commit b36b3c325, adding always-run Spread worker cleanup to manual CI jobs so cancelled or crashed tests do not leak GCP VMs. | |
| #2770 ci: always discard spread workers in snap-store-tests | charmcraft | closed | Closed unmerged after no reviews; the equivalent cleanup was merged for main in canonical/charmcraft#2771 via commit ff99aac2. | |
| #117 ci: always discard spread workers in build-rock tests (core24-8) | snapcraft-rocks | merged | Merged PR #117 (core24-8) adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in build-rock.yaml, so cancelled/crashed jobs don't leak GCP VMs for 2h (SNAPCRAFT-1368). Approved; +8/-0. | |
| #115 ci: always discard spread workers in build-rock tests (core22-8) | snapcraft-rocks | merged | PR #115 merged (+8/-0): adds an always-run 'Discard spread workers' step to the spread-tests job in .github/workflows/build-rock.yaml for core22-8, so cancelled/crashed jobs no longer leak spread GCP VMs (SNAPCRAFT-1368). | |
| #116 ci: always discard spread workers in build-rock tests (core22-7) | snapcraft-rocks | open | Adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in .github/workflows/build-rock.yaml (core22-7) so GCP VMs aren't leaked on cancellation (SNAPCRAFT-1368). +8/-0, spread-tests green, build-rock amd64/arm64 failing. | |
| #482 ci: always discard spread workers | rockcraft | merged | PR #482 by lengau merged: added an always-run "Discard spread workers" cleanup step (spread -discard -reuse-pid) to .github/workflows/spread.yaml, copied from snapcraft's spread.yml. | |
| #432 ci: speed up spread testing workflow | fetch-service | merged | Merged PR #432 (commit 9eec284), removing snap-test's dependency on snap-build so spread tests start sooner while snap-build still produces downloadable artifacts. |