build(lint): replicate rockcraft tombi integration in two commits
Metadata
Current evaluation
Adds tombi TOML formatting/linting support mirroring rockcraft#1363. CI failing on lint/files and OSV-scanner; awaiting review.
Suggested action: needs review
Reason: The PR adds tombi TOML formatting support mirroring rockcraft#1363, but CI is failing on 'lint / files' and 'Security scan / OSV-scanner' checks. With 0 reviewers and no comments after 25 days, it needs maintainer review to assess whether the CI failures are acceptable or require fixes before merging.
Evaluated by: mr-cal-bot
Impact:
15
Quick Win:
5
Complexity:
20
Confidence:
65
Actionability:
40
Issue body
This mirrors the tombi integration from canonical/rockcraft#1363 into Charmcraft, split as requested: first the non-TOML Starbase-aligned build/lint wiring, then the formatter-produced TOML rewrites.
- **Non-TOML Starbase sync**
- Added TOML-specific indentation in `.editorconfig`:
- `[*.toml]`
- `indent_size = 2`
- Updated top-level Make targets to include tombi:
- `format` now runs `format-tombi`
- `lint` now runs `lint-tombi`
- Added shared targets in `common.mk`:
- `format-tombi` (`tombi format`)
- `lint-tombi` (`tombi format --check --diff`)
- `install-tombi` installer path alongside existing tool installers
- **TOML formatting sweep**
- Applied tombi formatting updates to repository TOML files, including:
- root `pyproject.toml`
- spread fixture `pyproject.toml` files under `tests/spread/**`
```make
.PHONY: format-tombi
format-tombi: install-tombi
tombi format
.PHONY: lint-tombi
lint-tombi: install-tombi
tombi format --check --diff
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
5
Complexity:
20
Confidence:
65
Actionability:
40
|
needs review | Adds tombi TOML formatting/linting support mirroring rockcraft#1363. CI failing on lint/files and OSV-scanner; awaiting review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
0
Complexity:
10
Confidence:
95
Actionability:
0
|
close superseded | Replicates rockcraft's tombi TOML formatter integration into charmcraft's build/lint targets. Superseded by starbase update PR #2899 which already merged tombi support. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
4
Complexity:
20
Confidence:
55
Actionability:
35
|
needs review | Replicates rockcraft's tombi TOML formatting integration into charmcraft via two commits: build/lint wiring and TOML reformatting. CI failing on lint/files and OSV-scanner; no review activity in 24 days. | |
| ~deepseek/deepseek-pro-latest |
Impact:
30
Quick Win:
4
Complexity:
35
Confidence:
90
Actionability:
20
|
close superseded | Adds tombi TOML format/lint targets and reformats TOML files; superseded by merged starbase update #2899, with failing lint/files and OSV-scanner CI. | |
| ~deepseek/deepseek-pro-latest |
Impact:
30
Quick Win:
3
Complexity:
45
Confidence:
85
Actionability:
20
|
close superseded | Adds tombi TOML formatting/linting targets and reformats TOML files; open with failing lint/files and OSV-scanner CI, no reviews. | |
| stealth/space-bunny-alpha |
Impact:
30
Quick Win:
2
Complexity:
38
Confidence:
93
Actionability:
12
|
close superseded | Adds tombi formatting/lint wiring and reformats 25 files; now obsolete because merged Starbase sync charmcraft#2899 provides equivalent tooling, while lint/files and OSV-scanner fail. | |
| stealth/space-bunny-alpha |
Impact:
27
Quick Win:
2
Complexity:
34
Confidence:
99
Actionability:
10
|
close superseded | Tombi build/lint wiring and a 25-file TOML formatting sweep are obsolete: merged Starbase update #2899 landed equivalent tooling; this PR remains unreviewed with two failing checks. | |
| qwen/qwen3.8-27b |
Impact:
25
Quick Win:
5
Complexity:
35
Confidence:
65
Actionability:
30
|
needs review | Mirrors rockcraft#1363: adds tombi TOML formatter to Makefile (format-tombi/lint-tombi/install-tombi), .editorconfig TOML indent, and reformats repo TOML files. Open, unreviewed; CI has 2 failing checks (lint/files, OSV-scanner) and 6 pending. | |
| stealth/space-bunny-alpha |
Impact:
22
Quick Win:
4
Complexity:
35
Confidence:
62
Actionability:
30
|
keep open | Ports canonical/rockcraft#1363 tombi TOML lint/format wiring into Charmcraft: .editorconfig indent, format-tombi/lint-tombi/install-tombi Make targets, plus a repo-wide TOML reformat. No reviews yet; CI has 'lint / files' and OSV-scanner failing with 6 checks still pending. | |
| stealth/space-bunny-alpha |
Impact:
22
Quick Win:
8
Complexity:
32
Confidence:
89
Actionability:
55
|
needs review | Adds tombi format/lint installer targets, TOML-specific EditorConfig rules, and formatter rewrites across 25 files; reported CI passes, but two review comments remain unresolved. | |
| stealth/space-bunny-alpha |
Impact:
29
Quick Win:
12
Complexity:
33
Confidence:
87
Actionability:
60
|
needs review | Adds tombi TOML formatting and lint targets, TOML-specific EditorConfig rules, and formatter-driven rewrites across 25 files; all reported CI checks pass, with two review comments unresolved. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
13
Staleness:
10
Complexity:
15
Confidence:
70
|
needs review | Replicates rockcraft's tombi TOML formatting integration into charmcraft, split into two commits: build/lint wiring and TOML file reformatting. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
12
Staleness:
0
Complexity:
20
Confidence:
75
|
needs review | Adds tombi TOML formatting support to charmcraft, mirroring rockcraft#1363. Split into two commits: non-TOML build/lint wiring and TOML formatting sweep. CI passing, awaiting maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
20
Quick Win:
17
Staleness:
0
Complexity:
15
Confidence:
75
|
needs review | Ports tombi TOML formatting integration from rockcraft#1363 into charmcraft, adding lint/format targets and formatting existing TOML files. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/rockcraft#1363
(confidence 90%)
This PR explicitly mirrors the tombi integration from rockcraft#1363, which added the same TOML formatting support.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1363 build(lint): add tombi TOML formatting support | rockcraft | closed | Merged PR adding tombi TOML formatting/linting support to rockcraft's build workflow, pinning formatter version and reformatting repository TOML files. |