build(lint): replicate rockcraft tombi integration in two commits
Metadata
Current evaluation
Adds tombi TOML formatting support to charmcraft, mirroring rockcraft#1363. Split into two commits: non-TOML build/lint wiring and TOML formatting sweep. CI passing, awaiting maintainer review.
Suggested action: needs review
Reason: This is a fresh PR (0 days old) with CI passing that adds tombi TOML formatting support, mirroring work done in rockcraft#1363. The PR body mentions it was 'split as requested', suggesting prior maintainer feedback. It needs a maintainer review to approve the build/lint changes and the TOML formatting sweep.
Impact:
15
Quick Win:
12.0
Staleness:
0
Complexity:
20
Confidence:
75
Issue body
This mirrors the tombi integration from canonical/rockcraft#1363 into Charmcraft, split as requested: first the non-TOML Starbase-aligned build/lint wiring, then the formatter-produced TOML rewrites.
- **Non-TOML Starbase sync**
- Added TOML-specific indentation in `.editorconfig`:
- `[*.toml]`
- `indent_size = 2`
- Updated top-level Make targets to include tombi:
- `format` now runs `format-tombi`
- `lint` now runs `lint-tombi`
- Added shared targets in `common.mk`:
- `format-tombi` (`tombi format`)
- `lint-tombi` (`tombi format --check --diff`)
- `install-tombi` installer path alongside existing tool installers
- **TOML formatting sweep**
- Applied tombi formatting updates to repository TOML files, including:
- root `pyproject.toml`
- spread fixture `pyproject.toml` files under `tests/spread/**`
```make
.PHONY: format-tombi
format-tombi: install-tombi
tombi format
.PHONY: lint-tombi
lint-tombi: install-tombi
tombi format --check --diff
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
12.0
Staleness:
0
Complexity:
20
Confidence:
75
|
needs review | Adds tombi TOML formatting support to charmcraft, mirroring rockcraft#1363. Split into two commits: non-TOML build/lint wiring and TOML formatting sweep. CI passing, awaiting maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Impact:
20
Quick Win:
17.0
Staleness:
0
Complexity:
15
Confidence:
75
|
needs review | Ports tombi TOML formatting integration from rockcraft#1363 into charmcraft, adding lint/format targets and formatting existing TOML files. |
Update history
| Date | Change |
|---|---|
| updated | |
| created |
Related work
-
Related To:
canonical/rockcraft#1363
(confidence 90%)
This PR explicitly mirrors the tombi integration from rockcraft#1363, which added the same TOML formatting support to rockcraft.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1363 build(lint): add tombi TOML formatting support | rockcraft | open | Adds tombi TOML formatting support to rockcraft, porting changes from starbase. Has 1 approval with reviewer-requested changes recently addressed. CI passing. |