build(lint): add tombi TOML formatting support
Metadata
Current evaluation
Adds tombi TOML formatting support to rockcraft, porting changes from starbase. Has 1 approval with reviewer-requested changes recently addressed. CI passing.
Suggested action: needs review
Reason: PR has 1 approval but reviewer lengau requested changes (deviation from starbase, linting fixes) which were just addressed in commits f847537 and 5d5fa44. Needs a final review to confirm the changes satisfy the reviewer before merge.
Impact:
30
Quick Win:
22.5
Staleness:
5
Complexity:
25
Confidence:
75
Issue body
This brings the `starbase` tombi formatting change into `rockcraft`: add TOML formatting/linting targets in the shared make logic, then commit the repository TOML rewrites produced by `make format-tombi`. The formatter is pinned so local and CI output stay stable.
- **Build/format workflow**
- Add `format-tombi` to `format`
- Add `lint-tombi` to `lint`
- Wire both through shared `common.mk`
- **Formatter configuration**
- Add TOML-specific `indent_size = 2` to `.editorconfig`
- Pin tombi in `common.mk` via `uv tool run --from tombi==1.5.4 tombi`
- **Repository formatting sweep**
- Apply tombi formatting to repository TOML files, including the root `pyproject.toml` and TOML fixtures used by integration/spread tests
```make
TOMBI=uv tool run --from tombi==1.5.4 tombi
format-tombi: install-uv
$(TOMBI) format
lint-tombi: install-uv
$(TOMBI) format --check --diff
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
22.5
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Adds tombi TOML formatting support to rockcraft, porting changes from starbase. Has 1 approval with reviewer-requested changes recently addressed. CI passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
35
Quick Win:
28.0
Staleness:
5
Complexity:
20
Confidence:
85
|
needs review | Adds tombi TOML formatting/linting targets to the build system, pins tombi 1.5.4, updates .editorconfig, and reformats repository TOML files. Approved with CI passing and maintainer feedback addressed. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
12.75
Staleness:
5
Complexity:
15
Confidence:
85
|
needs review | Adds tombi TOML formatting/linting targets to build workflow, pins formatter version, and applies formatting to repository TOML files. Approved with 0 unresolved comments and passing CI. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
11.25
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Adds tombi TOML formatting to rockcraft build system, updates common.mk and .editorconfig, formats repository TOML files. Approved by 1 reviewer, author addressed feedback, but 2 CI checks failing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
20
Quick Win:
15.0
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Adds pinned tombi TOML formatting/linting targets to rockcraft's build system, including .editorconfig changes and repository-wide TOML reformatting. Maintainer requested reverting the third commit that deviates from starbase. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Likely Fixed By:
starbase#597
(confidence 90%)
This PR ports the tombi TOML formatting feature from starbase#597 into rockcraft. The starbase PR was merged, and this PR adapts it for rockcraft's shared make logic.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2878 build(lint): replicate rockcraft tombi integration in two commits | charmcraft | open | Adds tombi TOML formatting support to charmcraft, mirroring rockcraft#1363. Split into two commits: non-TOML build/lint wiring and TOML formatting sweep. CI passing, awaiting maintainer review. | |
| #597 feat: format toml files with tombi | starbase | closed | Merged to format TOML files using tombi, resolving issue #437. Approved by two reviewers with passing CI checks. The change replaces prior formatter options and enables configuration directly in pyproject.toml across four files. |