build(lint): add tombi TOML formatting support
Metadata
Current evaluation
Merged PR adding tombi TOML formatting/linting support to rockcraft's build workflow, pinning formatter version and reformatting repository TOML files.
Resolution: closed resolved
Reason: The PR was approved, all CI checks passed, merge conflicts were resolved, and it was merged into the project. The tombi TOML formatting tool was added to the build workflow with version pinning at 1.5.4.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This brings the `starbase` tombi formatting change into `rockcraft`: add TOML formatting/linting targets in the shared make logic, then commit the repository TOML rewrites produced by `make format-tombi`. The formatter is pinned so local and CI output stay stable.
- **Build/format workflow**
- Add `format-tombi` to `format`
- Add `lint-tombi` to `lint`
- Wire both through shared `common.mk`
- **Formatter configuration**
- Add TOML-specific `indent_size = 2` to `.editorconfig`
- Pin tombi in `common.mk` via `uv tool run --from tombi==1.5.4 tombi`
- **Repository formatting sweep**
- Apply tombi formatting to repository TOML files, including the root `pyproject.toml` and TOML fixtures used by integration/spread tests
```make
TOMBI=uv tool run --from tombi==1.5.4 tombi
format-tombi: install-uv
$(TOMBI) format
lint-tombi: install-uv
$(TOMBI) format --check --diff
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR adding tombi TOML formatting/linting support to rockcraft's build workflow, pinning formatter version and reformatting repository TOML files. | |
| qwen/qwen3.6-35b-a3b |
Impact:
25
Quick Win:
17
Complexity:
15
Confidence:
85
Actionability:
80
|
needs review | Adds tombi TOML formatting/linting to rockbuild workflow, pins formatter version, and reformats all TOML files. Approved, CI passing, merge conflicts resolved. | |
| ~deepseek/deepseek-pro-latest |
Impact:
35
Quick Win:
20
Complexity:
30
Confidence:
80
Actionability:
80
|
needs review | Adds tombi TOML formatting/linting targets via common.mk, pins tombi==1.5.4, sets indent_size=2 in .editorconfig, and reformats 8 TOML files. Approved, CI green, 3 checks pending. | |
| ~deepseek/deepseek-pro-latest |
Impact:
30
Quick Win:
18
Complexity:
30
Confidence:
80
Actionability:
85
|
needs review | Ports starbase's tombi TOML formatting: adds format-tombi/lint-tombi targets in common.mk, pins tombi==1.5.4, sets indent_size=2 in .editorconfig, and reformats 8 TOML files. Approved, CI green, 3 checks pending. | |
| stealth/space-bunny-alpha |
Impact:
30
Quick Win:
18
Complexity:
30
Confidence:
87
Actionability:
85
|
needs review | Ports starbase's tombi TOML formatting: format-tombi/lint-tombi targets in common.mk, tombi==1.5.4 pinned via uv tool run, indent_size=2 in .editorconfig, plus repo-wide TOML reformat (8 files). Approved with 0 unresolved comments; CI green, 3 checks still pending. | |
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
12
Complexity:
25
Confidence:
85
Actionability:
80
|
needs review | Ports starbase's tombi TOML formatting into rockcraft: format-tombi/lint-tombi make targets via common.mk, tombi==1.5.4 pin, .editorconfig indent_size=2, and repo-wide TOML reformat. Approved, feedback addressed, conflicts resolved; CI green except 3 pending checks. | |
| qwen/qwen3.8-27b |
Impact:
20
Quick Win:
10
Complexity:
35
Confidence:
85
Actionability:
80
|
needs review | Ports starbase's tombi TOML formatting into rockcraft: format-tombi/lint-tombi make targets in common.mk, pinned tombi==1.5.4, .editorconfig indent_size=2, and a mechanical reformat of repo TOML files. Approved, conflicts resolved, CI green with 3 checks pending. | |
| stealth/space-bunny-alpha |
Impact:
30
Quick Win:
19
Complexity:
25
Confidence:
78
Actionability:
85
|
needs review | Adds tombi TOML formatting/lint targets (format-tombi, lint-tombi) via common.mk plus .editorconfig indent and a repo-wide TOML reformat. Approved, CI green except 3 pending checks. | |
| stealth/space-bunny-alpha |
Impact:
30
Quick Win:
19
Complexity:
30
Confidence:
93
Actionability:
90
|
needs review | Adds pinned tombi format/lint targets and TOML-specific EditorConfig settings, with mechanical TOML fixture rewrites. Approved and review requests addressed; completed checks pass, while build, lint, and slow-test checks remain pending. | |
| stealth/space-bunny-alpha |
Impact:
25
Quick Win:
14
Complexity:
30
Confidence:
91
Actionability:
78
|
needs review | Adds pinned tombi formatting/lint targets and reformats repository TOML and fixtures; approved with no unresolved comments, awaiting remaining CI checks. | |
| qwen/qwen3.6-35b-a3b |
Impact:
20
Quick Win:
17
Staleness:
10
Complexity:
15
Confidence:
80
|
needs review | Adds tombi TOML formatting/linting targets to rockcraft build system, pins formatter version, and applies formatting to repository TOML files. Approved by one reviewer with all feedback addressed. | |
| qwen/qwen3.6-35b-a3b |
Impact:
30
Quick Win:
22
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Adds tombi TOML formatting support to rockcraft, porting changes from starbase. Has 1 approval with reviewer-requested changes recently addressed. CI passing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
35
Quick Win:
28
Staleness:
5
Complexity:
20
Confidence:
85
|
needs review | Adds tombi TOML formatting/linting targets to the build system, pins tombi 1.5.4, updates .editorconfig, and reformats repository TOML files. Approved with CI passing and maintainer feedback addressed. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
13
Staleness:
5
Complexity:
15
Confidence:
85
|
needs review | Adds tombi TOML formatting/linting targets to build workflow, pins formatter version, and applies formatting to repository TOML files. Approved with 0 unresolved comments and passing CI. | |
| qwen/qwen3.6-35b-a3b |
Impact:
15
Quick Win:
11
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Adds tombi TOML formatting to rockcraft build system, updates common.mk and .editorconfig, formats repository TOML files. Approved by 1 reviewer, author addressed feedback, but 2 CI checks failing. | |
| qwen/qwen3.6-35b-a3b |
Impact:
20
Quick Win:
15
Staleness:
5
Complexity:
25
Confidence:
75
|
needs review | Adds pinned tombi TOML formatting/linting targets to rockcraft's build system, including .editorconfig changes and repository-wide TOML reformatting. Maintainer requested reverting the third commit that deviates from starbase. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2878 build(lint): replicate rockcraft tombi integration in two commits | charmcraft | open | Adds tombi TOML formatting/linting support mirroring rockcraft#1363. CI failing on lint/files and OSV-scanner; awaiting review. | |
| #437 Auto-format TOML files | starbase | closed | TOML auto-formatting was implemented with tombi via PR #597, merged as commit 79fa93c, and added to formatting and lint targets. | |
| #597 feat: format toml files with tombi | starbase | closed | Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437. | |
| #451 style: format TOML files with tombi | imagecraft | closed | Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge. | |
| #506 style: format pyproject.toml with tombi | craft-cli | merged | Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes. | |
| #218 style: format pyproject.toml with tombi | craft-grammar | merged | Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes. | |
| #1213 style: format pyproject.toml with tombi | craft-application | merged | Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync. | |
| #277 style: format pyproject.toml with tombi | craft-platforms | closed | Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270. |