fix(hotfix/2.7): fix windows-build for a supported runner image
Metadata
Current evaluation
Fixed windows-build CI by switching from retired windows-2019 to windows-2022 runner and dynamically selecting the newest installed Windows SDK version instead of hardcoding a specific version.
Resolution: closed resolved
Reason: PR #2931 was merged to fix the non-functional windows-build job. It updated the runner image from retired windows-2019 to windows-2022 and made the SDK version selection dynamic to avoid future breakage when GitHub retires SDK versions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
## Summary
Stacked on #2929.
The `windows-build` job was completely non-functional on this branch: it pinned
`runs-on: windows-2019`, a runner image GitHub retired, so the job never got a
runner and sat `queued` forever. The whole `Tests` workflow therefore never
completed.
Two fixes, both in this PR:
1. Move the job to `windows-2022`, the image `run-tests` already uses.
2. The installer step hardcoded a Windows SDK version that `windows-2022` does
not ship, which failed the moment the job could actually run:
`The term 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\x64\signtool.exe' is not recognized as a name`.
`windows-2022` ships SDKs 10.0.17763.0, 10.0.19041.0, 10.0.22621.0 and
10.0.26100.0. Rather than swap one pinned version for another (which breaks
again when the image drops it), the step now picks the newest installed SDK
version directory.
Inno Setup and the timestamp service are unchanged.
> [!NOTE]
> Supersedes the closed PR #2933, which only covered the second fix.
## Test plan
CI: `windows-build` runs to completion, signs the exe, builds the inno and
msix installers, and uploads the artifacts.
> [!WARNING]
> Generated by an automated agent, not a human.
🤖 **BEEP BOOP I'M A TOASTER**
_Model:_ `step-5-preview-free`
_Harness:_ opencode CLI
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | closed resolved | Fixed windows-build CI by switching from retired windows-2019 to windows-2022 runner and dynamically selecting the newest installed Windows SDK version instead of hardcoding a specific version. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| updated | |
| created |
Related work
-
Superseded By:
charmcraft#2933
(confidence 95%)
PR #2933 only covered the SDK version fix and was superseded by #2931 which included both fixes.
-
Related To:
charmcraft#2929
(confidence 90%)
PR #2931 was stacked on #2929.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2940 ci(hotfix/2.7): fix windows-build for a supported runner image | charmcraft | merged | Fixed windows-build CI by switching to windows-2022 runner and dynamically selecting the newest Windows SDK version instead of hardcoding a retired path. Merged in #2940. | |
| #2933 fix(hotfix/2.7): resolve Windows SDK path at build time in windows-build | charmcraft | closed | Fixed Windows SDK path resolution in `windows-build` by dynamically selecting the newest SDK version, resolving build failures on `windows-2022`. |