← Back to issue list

fix(hotfix/2.7): resolve Windows SDK path at build time in windows-build

View original Github issue

Metadata

Project
charmcraft
Number
#2933
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Fixed Windows SDK path resolution in `windows-build` by dynamically selecting the newest SDK version, resolving build failures on `windows-2022`.

Resolution: closed resolved

Reason: PR #2933 resolves the hardcoded Windows SDK path issue by dynamically selecting the newest installed SDK version, allowing the `windows-build` step to complete successfully on the `windows-2022` runner.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary Stacked on #2932. Moving #2931's runner to `windows-2022` exposed that the installer step hardcodes a Windows SDK version that image does not ship: ``` The term 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\x64\signtool.exe' is not recognized as a name ``` `windows-2022` ships SDKs 10.0.17763.0, 10.0.19041.0, 10.0.22621.0 and 10.0.26100.0. Rather than swapping one pinned version for another (which breaks again when the image drops it), the step now picks the newest installed SDK directory. Inno Setup and the timestamp service are unchanged. ## Test plan CI: `windows-build` completes the "Build installer(s)" step and uploads the installer artifacts. > [!WARNING] > Generated by an automated agent, not a human. 🤖 **BEEP BOOP I'M A TOASTER** _Model:_ `step-5-preview-free` _Harness:_ opencode CLI

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Fixed Windows SDK path resolution in `windows-build` by dynamically selecting the newest SDK version, resolving build failures on `windows-2022`.

Update history

Date Change
closed
updated
updated
created

Related work

  • Related To: charmcraft#2932 (confidence 90%)

    PR #2933 is stacked on #2932.

Related issues

Issue Project State Summary Similarity
#2931 fix(hotfix/2.7): fix windows-build for a supported runner image charmcraft closed Fixed windows-build CI by switching from retired windows-2019 to windows-2022 runner and dynamically selecting the newest installed Windows SDK version instead of hardcoding a specific version.
83%
#2940 ci(hotfix/2.7): fix windows-build for a supported runner image charmcraft merged Fixed windows-build CI by switching to windows-2022 runner and dynamically selecting the newest Windows SDK version instead of hardcoding a retired path. Merged in #2940.
81%