← Back to issue list

utils: introduce get_host_architecture()

View original Github issue

Metadata

Project
charmcraft
Number
#333
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/charmcraft#333 (commit 27bf04e8, merge 2cd93470) added utils.get_host_architecture(), aligning manifest base-arch detection with the host arch used as default when bases is set without architectures.

Resolution: closed resolved

Reason: PR #333 was approved and merged into charmcraft; commit 27bf04e8 introduced get_host_architecture() (merge commit 2cd93470). Per cjp256's comment it deduplicates the existing host-arch logic so bases without an explicit architectures field defaults to the host architecture. The helper later became the default for CharmcraftProject.architectures and remains in use via craft-parts upstream (cleanup2a4fc273).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/charmcraft#333 (commit 27bf04e8, merge 2cd93470) added utils.get_host_architecture(), aligning manifest base-arch detection with the host arch used as default when bases is set without architectures.
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#333 (commit 27bf04e8; merge 2cd93470), adding get_host_architecture() to use the host architecture when bases is set without explicit architectures.
qwen/qwen3.6-35b-a3b — — Merged adds get_host_architecture() utility to determine host architecture as default when bases is specified in charmcraft.yaml without explicit architectures. Approved by two reviewers, passed CI, and modified two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Introduces get_host_architecture() to determine the host architecture as the default when bases are specified in charmcraft.yaml and architectures is omitted, aligning configuration handling.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#2a4fc273 (confidence 40%)

    Later commit 'chore(cleanup): use upstream get_host_architecture' switched to craft-parts' upstream helper.

Related issues

Issue Project State Summary Similarity
#1400 fix: always include architectures in charm manifest charmcraft merged Merged canonical/charmcraft#1400 to always serialize architecture fields in generated charm manifests, including inferred defaults; rendering and tests were updated across nine files.
71%
#4993 Use craft-platforms utilities snapcraft closed Fixed by merged PR #5205 (commit 3aacad74b, "refactor: use craft-platforms utilities"), which replaced snapcraft's own get_host_architecture/supported-architecture helpers with craft-platforms equivalents (CRAFT-3278).
70%