← Back to issue list

fix: always include architectures in charm manifest

View original Github issue

Metadata

Project
charmcraft
Number
#1400
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged canonical/charmcraft#1400 to always serialize architecture fields in generated charm manifests, including inferred defaults; rendering and tests were updated across nine files.

Resolution: closed resolved

Reason: PR #1400 was approved and merged into main. It changed manifest rendering to include unset/default architecture values while still excluding unset optional fields, with corresponding test updates.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#1400 to always serialize architecture fields in generated charm manifests, including inferred defaults; rendering and tests were updated across nine files.
stealth/space-bunny-alpha — closed resolved Merged #1400 to always include architectures in generated charm manifests, updating manifest handling and tests across nine files.
qwen/qwen3.6-35b-a3b — — Merged a fix to always include architectures in the charm manifest. Approved by three reviewers, the change updates nine files with 26 additions and 14 deletions, resolving the manifest generation issue.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix to always include architectures in the charm manifest.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1818 fix(lifecycle): allow building multi-arch charms charmcraft merged Merged to main as commit c787ea23 (PR #1818), letting Charmcraft's lifecycle builds handle charms with multiple run-on architectures; landed alongside Ruff 0.6.0 fixes from #1825. Fixes #1697.
73%
#1895 tests: check that architecture "all" works charmcraft merged Merged as f136def1, adding tests for architecture-independent charms using build-for: all and fixing #1698; prerequisite #1894 was merged.
73%
#1853 Incorrect information in Charmhub for ARM64 variants of a charm charmcraft closed Charmcraft incorrectly packed legacy-base manifests with every declared architecture. PR #1795 (8b16cae4) fixed this in 3.1.2; affected charms must be repacked.
72%
#333 utils: introduce get_host_architecture() charmcraft merged Merged PR canonical/charmcraft#333 (commit 27bf04e8, merge 2cd93470) added utils.get_host_architecture(), aligning manifest base-arch detection with the host arch used as default when bases is set without architectures.
71%