← Back to issue list

'charmcraft build' should pull in actions.yaml and config.yaml

View original Github issue

Metadata

Project
charmcraft
Number
#36
Type
pull request
State
merged
Author
chipaca
Labels
Created
Updated
Closed

Current evaluation

Merged after two reviewer approvals. The pull request implements automatic inclusion of actions.yaml and config.yaml during charmcraft builds, adding 80 lines across two files. Changes were successfully integrated.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two reviewer approvals. The pull request implements automatic inclusion of actions.yaml and config.yaml during charmcraft builds, adding 80 lines across two files. Changes were successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Updates charmcraft build to automatically package actions.yaml and config.yaml. The change was merged into the main branch by contributor chipaca without additional discussion.
qwen3.6-35b-a3b-mtp-q6 Updates charmcraft build to automatically bundle actions.yaml and config.yaml. The change was merged into the main branch by contributor chipaca without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1114 config: support use actions in charmcraft.yaml charmcraft merged Merged update allowing actions in charmcraft.yaml instead of separate actions.yaml. Includes refactoring to fix circular imports. Approved by one reviewer across 10 files with 345 additions and 3 deletions.
83%
#31 feat: charmcraft actions craft-actions merged Merged changes adding two GitHub Actions: charmcraft/setup installs Charmcraft and LXD, while charmcraft/pack builds charms. Approved by two reviewers with passing CI checks, the update adds 299 lines across six files to streamline workflows.
82%
#49 ci: test the charmcraft actions in more places craft-actions merged Merged after two approvals and passing all CI checks. The update expands the continuous integration pipeline to test charmcraft actions across additional build environments, modifying a single file with minor configuration changes.
78%
#1149 command: charmcraft init to use charmcraft.yaml only charmcraft merged Merged after review. Updated charmcraft init to use a unified charmcraft.yaml by default, replacing separate metadata, actions, and config files. Added profile descriptions and updated URLs. Initially blocked but eventually merged.
75%
#142 fix the action generated by 'charmcraft init' charmcraft merged Merged a fix for the action generated by charmcraft init, resolving issue #141. Approved by three reviewers and verified by the reporter. Corrects a generation bug in the init command.
75%
#91 First pass at 'charmcraft init' charmcraft merged Merged the initial 'charmcraft init' implementation. Approved by two reviewers, the PR adds 1087 lines across 24 files to scaffold charms. README.md, additional options, and interactive prompts require future updates.
75%
#31 Include config.yaml in built charm charmcraft closed The maintainer cherry-picked the relevant commit and merged it as a separate pull request (#60). After contributor agreement clearance, the change to include config.yaml in the built charm was successfully integrated.
74%
#46 New functionality from charmcraft (CRAFT-706). craft-cli merged Merged new charmcraft functionality (CRAFT-706) following approval from two reviewers. The update adds approximately 2000 lines across 13 files, successfully integrating the feature set into the codebase.
74%
#35 charmcraft doesn't support actions charmcraft closed Resolved by PR #36, which updated charmcraft to correctly copy actions.yaml into packaged charms, fixing the AttributeError when using the ops framework.
73%
#1126 Allow use actions/config/metadata in charmcraft.yaml charmcraft merged Merged. Allows defining actions, config, and metadata directly in charmcraft.yaml when corresponding files are absent. Addresses CRAFT-1747, CRAFT-1788, and CRAFT-1789. Approved with passing CI checks.
73%