← Back to issue list

Include config.yaml in built charm

View original Github issue

Metadata

Project
charmcraft
Number
#31
Type
pull request
State
closed
Author
charness
Labels
—
Created
Updated
Closed

Current evaluation

PR closed unmerged: #36 (commit a8cdb744) already added config.yaml to the built charm; maintainer cherry-picked this PR's separate test commit d6d5106 into #60 (e1944189, merged).

Resolution: closed superseded

Reason: Maintainer chipaca noted #36 also fixed the titular issue and, after the contributor agreement cleared, cherry-picked the only still-relevant commit d6d5106 into PR #60, which merged as e1944189. The remaining diff of this PR was never merged as-is.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Include config.yaml in the zipped charm if present in the source. Test both with and without a config.yaml in the simple-build case.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR closed unmerged: #36 (commit a8cdb744) already added config.yaml to the built charm; maintainer cherry-picked this PR's separate test commit d6d5106 into #60 (e1944189, merged).
stealth/space-bunny-alpha — closed superseded Closed after #36 implemented config.yaml inclusion; the maintainer cherry-picked d6d5106’s separate test change and merged it via #60.
qwen/qwen3.6-35b-a3b — — The maintainer cherry-picked the relevant commit and merged it as a separate pull request (#60). After contributor agreement clearance, the change to include config.yaml in the built charm was successfully integrated.
qwen3.6-35b-a3b-mtp-q6 — — Cherry-picked after CLA clearance and closed. The config.yaml inclusion change was merged via PR #60, superseding this pull request.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/charmcraft#36 (confidence 95%)

    Merged PR #36 (a8cdb744) added actions.yaml/config.yaml inclusion to charmcraft build, covering the main change here.

  • Related To: canonical/charmcraft#60 (confidence 90%)

    Cherry-pick of d6d5106 landed as #60 (e1944189), fixing the stray test zip cleanup.

Related issues

Issue Project State Summary Similarity
#36 'charmcraft build' should pull in actions.yaml and config.yaml charmcraft merged Merged PR #36 as commit a8cdb744, making charmcraft build automatically include actions.yaml and config.yaml in charm builds.
71%