← Back to issue list

providers: introduce clean_project_environments() (CRAFT-314)

View original Github issue

Metadata

Project
charmcraft
Number
#410
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged to introduce clean_project_environments(), providing an interface for an upcoming clean command that removes all environments for a given project. Approved by two reviewers, adding 106 lines across two files.

Suggested action:

No scores available.

Issue body

Provide interface for upcoming 'clean' command to clean all environments created for a given project. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to introduce clean_project_environments(), providing an interface for an upcoming clean command that removes all environments for a given project. Approved by two reviewers, adding 106 lines across two files.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces clean_project_environments() to provide an interface for the upcoming clean command, enabling removal of all environments created for a given project.
qwen3.6-35b-a3b-mtp-q6 Merged. Introduces clean_project_environments() to provide an interface for an upcoming clean command that removes all environments created for a given project.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3929 providers: refactor clean_project_environments snapcraft merged Merged a refactor to the craft-providers interface, removing get_instance_name() from clean_project_environments() and renaming is_provider_available() to is_provider_installed(). Aligns with rockcraft, passed CI, and increased coverage by 0.13%.
76%
#93 commands: add clean command rockcraft merged Merged rockcraft clean command with stubbed TODOs for cleaning parts, destructive mode, and provider environments. Establishes groundwork for refactoring clean_project_environments(). Approved and merged despite a documentation request.
74%
#95 providers: add `create_environment` method rockcraft merged Merged the addition of a create_environment method to the providers module. The method supports clean_project_environment and aligns with snapcraft and charmcraft implementations. Approved by one reviewer and passed CI checks.
73%
#406 providers: introduce get_command_environment() to build env (CRAFT-262) charmcraft merged Merged PR introducing get_command_environment() to build container command environments with CHARMCRAFT_MANAGED_MODE=1 and proxy settings. Added a reviewer-requested test filtering random environment variables. Approved and passed CI.
72%
#3216 build providers: tweak environment clean detection and logging snapcraft merged Merged. Updated build environment cleaning detection and logging messages for accuracy and consistency. Refactored checks into a single _check_environment_needs_cleaning() function to consolidate clean_project() calls. Approved and merged by maintainer cjp256.
71%
#409 providers: introduce launch_environment() (CRAFT-312) charmcraft merged Merged. Introduces launch_environment() to launch and configure an LXC container for charmcraft, including buildd remote setup. Approved by two reviewers, adding 163 lines across two files.
70%