clean: introduce clean command (CRAFT-62)
Metadata
Current evaluation
Merged PR #412 (commit 23db6367, merge 646bc259) added a `clean` command removing Charmcraft-created LXD build containers, plus a caplog filter fixture. Later removed as unused in #1571.
Resolution: closed resolved
Reason: The PR itself was merged into main via merge commit 646bc259 (approved by 2 reviewers) delivering the CRAFT-62 `clean` command and test fixture. The implementation was later dropped in commit 053d5a2d (#1571) as unused.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Initial usage will clean any LXD containers created by Charmcraft
to build the project. Future work will further extend functionality.
Add a caplog filter fixture to help with a common pattern of checking
logs for the module under test.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #412 (commit 23db6367, merge 646bc259) added a `clean` command removing Charmcraft-created LXD build containers, plus a caplog filter fixture. Later removed as unused in #1571. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #412 via 646bc259, adding a clean command to remove Charmcraft-created LXD build containers and a caplog filter fixture for tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Introduces a clean command to remove LXD containers built by Charmcraft and adds a caplog filter fixture for testing. Approved by two reviewers, the update modifies five files with 116 additions and 4 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged a change introducing a clean command to remove LXD containers created by Charmcraft during builds. Also added a caplog filter fixture to simplify test log verification. Integrated by maintainer cjp256. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1571
(confidence 90%)
Commit 053d5a2d 'refactor: remove unused clean command implementation' removed the clean command introduced here, along with later provider refactors (CRAFT-334, CRAFT-362).
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #1420 fix: use craft-application clean command | charmcraft | closed | PR #1420 (switch clean to craft-application) was closed unmerged, with no matching commit in charmcraft/commands/clean.py history. The same cleanup landed later via merged PR #1571 (commit 053d5a2d), which deleted the redundant clean command. | |
| #1046 hook: clean charmcraft images when update/remove | charmcraft | merged | Merged #1046 in commit 49227423, adding hooks that remove legacy base resources, all Charmcraft LXD instances, and the Charmcraft project. | |
| #93 commands: add clean command | rockcraft | merged | Merged as c4502a7a via PR #93, adding the rockcraft clean command scaffold with TODO paths for part, destructive-mode, and provider cleanup. | |
| #3680 commands, parts: add clean command | snapcraft | merged | Merged #3680 via 35ecc5c64, adding a clean command for parts and build-instance cleanup outside destructive or managed modes. | |
| #1655 lxd: distinguish argless clean from clean -s pull | snapcraft | merged | Merged in snapcraft#1655 (ed32603c7), fixing LXD cleanup so bare clean removes build containers while clean -s pull preserves or recreates them. | |
| #1338 `charmcraft clean` doesn't clean | charmcraft | closed | Closed unresolved: LXD cleanup remained broken in Charmcraft 3, with the changed behavior attributed to craft-application#425, which also closed without a linked fix. |