← Back to issue list

build: pack charm in provided environment when using bases (CRAFT-313)

View original Github issue

Metadata

Project
charmcraft
Number
#411
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged implementation for packing charms in provided environments per bases configuration (CRAFT-313). Approved by two reviewers, modifying two files (+175/-30). Future work will add verbose and quiet mode flag support.

Suggested action:

No scores available.

Issue body

For each bases configuration, check if a build-on base can be provided. If so, launch environment and execute pack command inside each to build charm for each viable bases config index. Future work should extend the pack command to include the parent's verbose or quiet mode flags for consistency. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged implementation for packing charms in provided environments per bases configuration (CRAFT-313). Approved by two reviewers, modifying two files (+175/-30). Future work will add verbose and quiet mode flag support.
qwen3.6-35b-a3b-mtp-q6 Merged PR implements CRAFT-313 by updating the pack command to automatically launch build environments and construct charms for each viable bases configuration index.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer cjp256. Enables packing charms in provided environments for each viable bases configuration index, resolving CRAFT-313. Future updates will add verbose and quiet mode flag support.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#390 build/pack: add support for bases in managed mode (CRAFT-131) charmcraft merged Merged changes adding bases support for managed mode in build/pack. Introduces a bases module, extends configuration validation with warnings, and updates run() to return built charms. Approved by two reviewers and merged.
83%
#428 build: inform user that packing charm may take time (CRAFT-347) charmcraft merged Merged implementation adds progress feedback during charm packing to inform users of duration. Refactored environment logic to retrieve the charm name earlier. Approved by two reviewers and passed CI checks.
81%
#383 commands/build: charm file name format support for bases (CRAFT-66) charmcraft merged Merged following approval by three reviewers. Introduces charm file name format support for bases configuration, preserving the existing format as a legacy runtime path. Includes corresponding tests. (+98/-1 lines, 2 files changed)
80%
#324 Provide the building charms functionality through the pack command. charmcraft merged Merged. Implements building charms functionality via the pack command. Approved by three reviewers, modifying four files (+219/-30 lines).
79%
#418 build/pack: pass --verbose or --quiet as needed (CRAFT-322) charmcraft merged Merged implementation that passes --verbose or --quiet flags to managed build instances, aligning them with the host charmcraft instance. Approved by two reviewers and applied across four files.
76%
#1795 fix(package): Limit the bases in manifest.yaml charmcraft merged Merged a fix correcting manifest.yaml generation for bases charms. The build previously output all run bases instead of only the specific bases for the current build. Approved by two reviewers, modified 8 files.
73%
#892 (internal) Remove CharmcraftBuilddBaseConfiguration and use BuilddBase directly (CRAFT-1278, CRAFT-1356). charmcraft merged Removed CharmcraftBuilddBaseConfiguration in favor of direct BuilddBase usage. Merged after single reviewer approval, modifying six files and resolving CRAFT-1278 and CRAFT-1356.
73%
#541 charm_builder: build dependencies locally (CRAFT-537) charmcraft merged Merged changes to charm_builder that build binary dependencies locally instead of installing them. A persistent virtual environment caches dependencies to prevent rebuilds. Approved by two reviewers, passed CI, and modified seven files.
72%
#281 Include a manifest in the built result when packing charms and bundles. charmcraft merged Merged changes add a manifest to packaged charms and bundles, resolving issue #273. The Builder now receives configuration, requiring test updates across seven files. Approved by two reviewers and integrated.
72%
#777 Do not modify the charm's project when packing using the reactive plugin (CRAFT-928). charmcraft merged Merged to resolve issue #693. The change prevents the reactive plugin from modifying the charm's project during packing. Approved by one reviewer with zero unresolved comments. Two files modified, netting a 21-line reduction.
72%