commands/build: charm file name format support for bases (CRAFT-66)
Metadata
Current evaluation
Merged PR #383 (commit 951f6aaa; merge 1c839909) added bases-aware charm filename formatting and tests, retaining the legacy runtime path pending default-bases configuration.
Resolution: closed resolved
Reason: PR #383 was merged in commit 951f6aaa with merge commit 1c839909, delivering CRAFT-66 filename-format support and tests. Its description confirms the legacy path remained active until default bases configuration was added.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Maintain current format as "legacy" until we have the (default) bases
configuration available in upcoming PRs. Note that only the legacy
path is utilized at runtime, with tests added for bases configuration
support.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #383 (commit 951f6aaa; merge 1c839909) added bases-aware charm filename formatting and tests, retaining the legacy runtime path pending default-bases configuration. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #383 (commit 951f6aaa), adding bases-aware charm filename format support and tests while retaining the legacy runtime path pending default-bases configuration. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in charmcraft#383, adding charm filename format support for bases configuration while retaining the existing format as the legacy runtime path; tests cover bases configuration. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval by three reviewers. Introduces charm file name format support for bases configuration, preserving the existing format as a legacy runtime path. Includes corresponding tests. (+98/-1 lines, 2 files changed) | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds charm file name format support for bases configuration, keeping the legacy format as the default runtime path while introducing tests for upcoming bases configuration updates. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#414
(confidence 90%)
Follow-up default-bases configuration was merged in commit 3bfa45c0, matching the prerequisite noted by PR #383.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #411 build: pack charm in provided environment when using bases (CRAFT-313) | charmcraft | merged | Merged PR #411 (CRAFT-313) to pack each viable bases configuration in its provided build environment; merge commit 523c6fb0. | |
| #299 [WIP] charmcraft config: introduce support for bases keyword | charmcraft | closed | Abandoned WIP; bases support landed separately through merged PRs #339 (9af3b121) and #341 (b76170f9), covering long- and short-form configurations. | |
| #73 Add multi-bases support for charm build plans | craft-platforms | closed | Multi-base charm build-plan support was merged in PR #81 (commit 519b705), with validation tightening and error-handling updates; it resolved #73. | |
| #215 fix(charm): accept redundant multi-base charms | craft-platforms | merged | Merged PR #215 as commit 4879309, allowing redundant multi-base charms when they produce equivalent valid build plans and addressing canonical/charmcraft#2620. | |
| #148 feat(charm): add a build planner for bases charms | craft-platforms | merged | Merged PR #148 added a Charm build planner for legacy charms using the bases key, addressing CHARMCRAFT-630 in commit 16ff218. | |
| #81 feat: multi-base support for charm build plans | craft-platforms | merged | Merged PR #81 as commit 519b705, adding multi-base charm build-plan support and fixing #73, with stricter shorthand validation and CraftPlatformsError. | |
| #479 The control of `bases` in `charmcraft.yaml` should be different for bundles | charmcraft | closed | Fixed by merged PR #545: bundles no longer warn when bases is omitted, and bundle configurations declaring bases are rejected. | |
| #791 Enforced DN03: the 'bases' is now mandatory for charms in the config (CRAFT-785). | charmcraft | merged | Merged PR canonical/charmcraft#791 (9c52a73a), enforcing DN03 so charm configs require bases and updating affected tests; fixes #655. | |
| #1030 login, names and register should not fail with "The field 'bases' is mandatory when type=charm" | charmcraft | closed | Fixed by merged PR #1035 (commit 91a5f553): login, register, and names no longer fail when run in charm source directories without a bases field. | |
| #2174 charmcraft pack outputs different charm filenames depending on base/platform specification in charmcraft.yaml | charmcraft | closed | Closed as working as intended: deprecated bases preserve Charmcraft 2.x naming, while platforms keys intentionally control the filename suffix. |