commands/build: charm file name format support for bases (CRAFT-66)
Metadata
Current evaluation
Merged following approval by three reviewers. Introduces charm file name format support for bases configuration, preserving the existing format as a legacy runtime path. Includes corresponding tests. (+98/-1 lines, 2 files changed)
Suggested action: —
No scores available.
Issue body
Maintain current format as "legacy" until we have the (default) bases
configuration available in upcoming PRs. Note that only the legacy
path is utilized at runtime, with tests added for bases configuration
support.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval by three reviewers. Introduces charm file name format support for bases configuration, preserving the existing format as a legacy runtime path. Includes corresponding tests. (+98/-1 lines, 2 files changed) | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds charm file name format support for bases configuration, keeping the legacy format as the default runtime path while introducing tests for upcoming bases configuration updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Implements charm file name format support for bases configuration, preserving the current format as legacy until default bases configuration is available. Adds tests for bases support, with only the legacy path active at runtime. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #411 build: pack charm in provided environment when using bases (CRAFT-313) | charmcraft | merged | Merged implementation for packing charms in provided environments per bases configuration (CRAFT-313). Approved by two reviewers, modifying two files (+175/-30). Future work will add verbose and quiet mode flag support. | |
| #390 build/pack: add support for bases in managed mode (CRAFT-131) | charmcraft | merged | Merged changes adding bases support for managed mode in build/pack. Introduces a bases module, extends configuration validation with warnings, and updates run() to return built charms. Approved by two reviewers and merged. | |
| #299 [WIP] charmcraft config: introduce support for bases keyword | charmcraft | closed | Charmcraft bases keyword support was closed without merging. The branch was abandoned with twelve unresolved review comments and pending unit tests, leaving the feature unimplemented. | |
| #791 Enforced DN03: the 'bases' is now mandatory for charms in the config (CRAFT-785). | charmcraft | merged | Merged. Enforced mandatory 'bases' field in charm configuration per DN03 (CRAFT-785), resolving #655. Updated config and tests to include bases or switched test types to bundle. Approved by one reviewer and passed CI. | |
| #471 config: add charm part to documentation (CRAFT-356) | charmcraft | merged | Merged changes adding charm configuration documentation to the configuration schema. Approved by two reviewers with zero unresolved comments. Updated two files with 15 additions and one deletion. Resolves CRAFT-356. | |
| #1795 fix(package): Limit the bases in manifest.yaml | charmcraft | merged | Merged a fix correcting manifest.yaml generation for bases charms. The build previously output all run bases instead of only the specific bases for the current build. Approved by two reviewers, modified 8 files. | |
| #1554 feat: implement platforms for building charms | charmcraft | merged | Merged implementation of platforms for building charms, replacing the deprecated bases field per ST105 spec. Resolves #1535 and depends on #1556 for testing. Approved by reviewers with passing CI checks. | |
| #1622 fix: reorganise charmcraft.yaml preprocessing | charmcraft | merged | Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines). | |
| #341 config: add short-form bases support (CRAFT-11) | charmcraft | merged | Merged: Added short-form bases support to configuration, resolving CRAFT-11. Approved by two reviewers, the change adds 130 lines across two files to allow bases to imply their long-form build-on/run-on equivalents. | |
| #324 Provide the building charms functionality through the pack command. | charmcraft | merged | Merged. Implements building charms functionality via the pack command. Approved by three reviewers, modifying four files (+219/-30 lines). |