Use linters' analyze from build command (CRAFT-318)
Metadata
Current evaluation
Merged. Integrated linter analysis into the build command to log attributes and update manifest creation. Fixed a missing integration test in checkers/analyze. Approved by reviewers and passed CI checks.
Suggested action: —
No scores available.
Issue body
Call linters' analyze from build command and deal with the results: so far only log the attribute ones (in the future it will deal also with warnings and errors), and use them for the manifest creation. Also changed the manifest creation function to properly save this new info.
Note: I had to fix checkers/analyze to save information in the shared state (a checkers integration test was missing).
Note 2: This PR depends on #443.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Integrated linter analysis into the build command to log attributes and update manifest creation. Fixed a missing integration test in checkers/analyze. Approved by reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes integrating linter analysis into the build command, logging attributes and updating manifest creation. Fixed shared state saving in checkers/analyze, added a missing integration test, and applied minor naming corrections. Depends on PR #443. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged: Integrates linter analysis into the build command, logging attributes and updating manifest creation. Includes fixes to checkers/analyze for shared state persistence and depends on PR #443. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #455 Added an "analyze" command that exposes the linters/attributes results (CRAFT-319). | charmcraft | merged | Merged, adding an analyze command to expose linters and attributes results, resolving CRAFT-319. Approved by two reviewers, the change modifies six files with 444 additions and 4 deletions. | |
| #451 Handle linters when building (CRAFT-325). | charmcraft | merged | Merged implementation for handling linters during build. The change surfaces errors and warnings, failing unless --force is passed to pack. Approved by two reviewers and depends on PR #449. | |
| #416 Created the Language checker, first step in the analyze/lint structure (CRAFT-285) | charmcraft | merged | Merged the language checker, establishing the initial analyze/lint structure. Approved by two reviewers after addressing 18 comments, the change adds 168 lines across two files for CRAFT-285. | |
| #460 Isolated the linters/checkers, no more shared state between them (CRAFT-383). | charmcraft | merged | Merged refactoring that isolates linters and checkers to eliminate shared state, preventing failures when dependency checkers are ignored or crash. Approved by three reviewers, passed CI, and modified two files. | |
| #449 Added a linter to verify that the metadata is ok (CRAFT-322). | charmcraft | merged | Merged after approval, adding a linter to verify metadata. The change depends on a separate analint PR and introduces validation checks, though enforcement during packing is deferred to a future release. |