Use linters' analyze from build command (CRAFT-318)
Metadata
Current evaluation
Merged PR #445 implemented CRAFT-318: builds invoke linters.analyze, log attribute findings, and persist analysis data in manifests; checker shared state and tests were fixed.
Resolution: closed resolved
Reason: PR #445 was merged after approval, implementing CRAFT-318 and incorporating prerequisite changes from merged PR #443 (merge commit 6855c666).
Evaluated by: mr-cal-bot
No scores available.
Issue body
Call linters' analyze from build command and deal with the results: so far only log the attribute ones (in the future it will deal also with warnings and errors), and use them for the manifest creation. Also changed the manifest creation function to properly save this new info.
Note: I had to fix checkers/analyze to save information in the shared state (a checkers integration test was missing).
Note 2: This PR depends on #443.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #445 implemented CRAFT-318: builds invoke linters.analyze, log attribute findings, and persist analysis data in manifests; checker shared state and tests were fixed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged CRAFT-318: builds now invoke linters.analyze, log attribute findings, and persist analysis data in manifests; checker shared-state handling and coverage were also fixed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Integrated linter analysis into the build command to log attributes and update manifest creation. Fixed a missing integration test in checkers/analyze. Approved by reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes integrating linter analysis into the build command, logging attributes and updating manifest creation. Fixed shared state saving in checkers/analyze, added a missing integration test, and applied minor naming corrections. Depends on PR #443. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#443
(confidence 99%)
Explicit prerequisite merged as commit 6855c666, preventing ignored attributes and linters from running.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #455 Added an "analyze" command that exposes the linters/attributes results (CRAFT-319). | charmcraft | merged | Merged into main as 9ac04412 via #455, adding an analyze command that exposes charm linter and attribute results for CRAFT-319. | |
| #451 Handle linters when building (CRAFT-325). | charmcraft | merged | Merged PR #451 (commit 5e30db2a, branch facundobatista/analint08-enforce-linter-maybe, commit 74ec7adc) wiring linters into the build/pack flow: reports errors and warnings, fails on errors unless pack got --force. Depended on merged #449. |