← Back to issue list

Handle linters when building (CRAFT-325).

View original Github issue

Metadata

Project
charmcraft
Number
#451
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #451 (commit 5e30db2a, branch facundobatista/analint08-enforce-linter-maybe, commit 74ec7adc) wiring linters into the build/pack flow: reports errors and warnings, fails on errors unless pack got --force. Depended on merged #449.

Resolution: closed resolved

Reason: The PR itself was merged into main via commit 5e30db2a ("Merge pull request #451 from facundobatista/analint08-enforce-linter-maybe"), implementing the change in commit 74ec7adc "Handle linters when building." It had 2 approving reviewers and its prerequisite PR #449 (metadata linter, ccc10f3e) was already merged.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Show errors and warnings. Fail if there are some errors, unless `--force` was indicated to `pack` (not to `build`, which we want to not touch until we remove it). Note this depends on #449.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #451 (commit 5e30db2a, branch facundobatista/analint08-enforce-linter-maybe, commit 74ec7adc) wiring linters into the build/pack flow: reports errors and warnings, fails on errors unless pack got --force. Depended on merged #449.
stealth/space-bunny-alpha — closed resolved Merged #451 in commit 5e30db2a, reporting linter errors and warnings during builds and failing on errors unless pack received --force. Prerequisite #449 had already merged.
qwen/qwen3.6-35b-a3b — — Merged implementation for handling linters during build. The change surfaces errors and warnings, failing unless --force is passed to pack. Approved by two reviewers and depends on PR #449.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Implements linter validation during the build process, displaying errors and warnings and failing on errors unless the --force flag is passed to the pack command. Depends on PR 449.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#449 (confidence 88%)

    Stated dependency in the PR body; added the metadata linter that #451 enforces at pack time (merged ccc10f3e).

  • Related To: canonical/charmcraft#455 (confidence 62%)

    Follow-up CRAFT-319 PR (9ac04412) exposing linter/attribute results via a new 'analyze' command, extending the linter work this PR began.

  • Related To: canonical/charmcraft#460 (confidence 55%)

    Follow-up CRAFT-383 PR (545418b7) refactoring the checkers/linters that this PR invoked, removing shared state.

  • Related To: canonical/charmcraft#443 (confidence 45%)

    Earlier linter-analysis PRs (1483830f used linters' analyze from build command) in the same analysis/linter series leading up to this enforcement PR.

Related issues

Issue Project State Summary Similarity
#445 Use linters' analyze from build command (CRAFT-318) charmcraft merged Merged PR #445 implemented CRAFT-318: builds invoke linters.analyze, log attribute findings, and persist analysis data in manifests; checker shared state and tests were fixed.
73%
#18 lint: update linters craft-archives merged Merged in canonical/craft-archives#18 via commit 41edc5b, updating linters across two files.
72%
#907 feat(linter): add linter service framework craft-application merged Merged PR #907 as commit a76bcaa6, adding a shared Linter Service for consistent downstream registration and execution of linters and closing craft-application#782.
70%