← Back to issue list

Handle linters when building (CRAFT-325).

View original Github issue

Metadata

Project
charmcraft
Number
#451
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged implementation for handling linters during build. The change surfaces errors and warnings, failing unless --force is passed to pack. Approved by two reviewers and depends on PR #449.

Suggested action:

No scores available.

Issue body

Show errors and warnings. Fail if there are some errors, unless `--force` was indicated to `pack` (not to `build`, which we want to not touch until we remove it). Note this depends on #449.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged implementation for handling linters during build. The change surfaces errors and warnings, failing unless --force is passed to pack. Approved by two reviewers and depends on PR #449.
qwen3.6-35b-a3b-mtp-q6 Merged. Implements linter validation during the build process, displaying errors and warnings and failing on errors unless the --force flag is passed to the pack command. Depends on PR 449.
qwen3.6-35b-a3b-mtp-q6 Merged PR implementing linter checks during the build process. The build fails on errors unless the --force flag is passed to the pack command. Implementation depends on PR #449.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#445 Use linters' analyze from build command (CRAFT-318) charmcraft merged Merged. Integrated linter analysis into the build command to log attributes and update manifest creation. Fixed a missing integration test in checkers/analyze. Approved by reviewers and passed CI checks.
75%
#443 Don't run the ignored attributes and linters (CRAFT-326) charmcraft merged Merged pull request preventing execution of ignored attributes and linters. Approved by two reviewers, the fix modifies four files with 289 additions and 22 deletions to resolve CRAFT-326.
72%
#449 Added a linter to verify that the metadata is ok (CRAFT-322). charmcraft merged Merged after approval, adding a linter to verify metadata. The change depends on a separate analint PR and introduces validation checks, though enforcement during packing is deferred to a future release.
72%
#460 Isolated the linters/checkers, no more shared state between them (CRAFT-383). charmcraft merged Merged refactoring that isolates linters and checkers to eliminate shared state, preventing failures when dependency checkers are ignored or crash. Approved by three reviewers, passed CI, and modified two files.
70%