← Back to issue list

Allow including resources when releasing charms directly in the upload command (CRAFT-381).

View original Github issue

Metadata

Project
charmcraft
Number
#457
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #457 (b5d735b4), adding --resource support to upload --release and fixing #456; the fix shipped in Charmcraft 1.1.2.

Resolution: closed resolved

Reason: The merged implementation parses repeated --resource values and passes them to the release operation when uploading with --release. Commit b5d735b4 fixed #456 and shipped in Charmcraft 1.1.2.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes 456.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #457 (b5d735b4), adding --resource support to upload --release and fixing #456; the fix shipped in Charmcraft 1.1.2.
stealth/space-bunny-alpha — closed resolved PR #457 merged as b5d735b4, adding --resource support to `charmcraft upload --release` (CRAFT-381) and fixing the internal error in #456; shipped in Charmcraft 1.1.2.
stealth/space-bunny-alpha — closed resolved Merged PR #457 (b5d735b4), adding resource support for charmcraft upload --release and fixing #456; released in Charmcraft 1.1.2.
stealth/space-bunny-alpha — closed resolved Merged #457 as b5d735b4 (ad3a5172), adding resource support to upload --release and fixing #456. The regression fix shipped in Charmcraft 1.1.2.
qwen/qwen3.6-35b-a3b — — Merged. Enables including resources when releasing charms via the upload command, fixing issue #456 and CRAFT-381. Approved by two reviewers with 63 additions across three files. Maintainers prioritized CI workflow improvements.
qwen3.6-35b-a3b-mtp-q6 — — Merged to fix issue #456. Enables including resources directly in the charm upload command. Maintainers accepted the implementation for CI/CD support, deferring stricter error handling and documentation updates.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#456 (confidence 100%)

    PR #457 explicitly fixes the upload --release internal-error issue.

Related issues

Issue Project State Summary Similarity
#259 Support for attaching resources when releasing charms. charmcraft merged Merged PR #259 in commit 35855e58, adding resource attachment support when releasing charms through the upload command.
84%
#126 Add a "--release" option to the "upload" command charmcraft closed Implemented charmcraft upload --release in canonical/charmcraft#255 (merge 9064a3f3, feature bc06a62a); #457 added resource support and shipped in Charmcraft 1.1.2.
83%
#847 Improve the 'release' response when resources are automatically released with the charm charmcraft open Enhance charmcraft release output to list resources Charmhub automatically attaches; the backend fix is available, but current output only reports resources passed with --resource.
79%
#1979 `charmcraft upload` should allow a user to also release the charm charmcraft open Requests single-command charm upload+release with automatic OCI resource handling. --release flag already exists; remaining gap is resource upload by image reference instead of revision number.
76%
#255 Add the option to release when uploading a charm or bundle charmcraft merged Merged PR #255 as 9064a3f3, adding upload-time release channel support for charms and bundles; implementation commit bc06a62a.
75%
#176 Support for charms' resources charmcraft closed Resource support was completed by merged PRs #252, #253, #259, and #262, covering listing, uploading, release attachment, and status output.
75%
#1313 Make it easier to release charms in CI and in general charmcraft open Single-command charm upload and release with OCI resources remains unimplemented; upload accepts only existing resource revisions, so users must upload resources first and track returned IDs.
75%
#1736 fix: fix some edge cases with resource uploads charmcraft merged Merged PR #1736 as commit 97603da4, fixing resource-upload edge cases and resolving charmcraft#1712's empty-resource spread-test failure.
74%
#682 Allow for resources with a rev of 0 during `charmcraft release` charmcraft merged Merged PR #682 fixed charmcraft release rejecting resource revision 0, resolving #679. Implementation f17debfa landed via merge commit 434361d0.
74%
#2171 "Publish a charm to Charmhub" should include an example with your first resource. charmcraft closed Documentation now shows how to attach a resource revision when releasing a charm; fixed by merged PR canonical/charmcraft#2172 (commit df9125d6).
74%