fix: fix some edge cases with resource uploads
Metadata
Current evaluation
Merged PR #1736 as commit 97603da4, fixing resource-upload edge cases and resolving charmcraft#1712's empty-resource spread-test failure.
Resolution: closed resolved
Reason: PR #1736 was approved and merged as commit 97603da4. Its description explicitly states that it fixes charmcraft#1712.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes #1712
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1736 as commit 97603da4, fixing resource-upload edge cases and resolving charmcraft#1712's empty-resource spread-test failure. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1736 as commit 97603da4, fixing resource-upload edge cases and explicitly addressing charmcraft#1712. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/charmcraft#1736 as commit 97603da4 after two approvals, fixing resource-upload edge cases and resolving charmcraft#1712. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved edge cases in resource uploads, addressing issue #1712. Approved by two reviewers, the changes modify four files (+14/-12 lines) and have been successfully merged into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for resource upload edge cases, resolving issue #1712. Changes address upload handling inconsistencies and were successfully integrated into the main branch by maintainer lengau. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#1712
(confidence 100%)
The broken store-resources spread test was the issue explicitly fixed by PR #1736.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #457 Allow including resources when releasing charms directly in the upload command (CRAFT-381). | charmcraft | merged | Merged PR #457 (b5d735b4), adding --resource support to upload --release and fixing #456; the fix shipped in Charmcraft 1.1.2. | |
| #682 Allow for resources with a rev of 0 during `charmcraft release` | charmcraft | merged | Merged PR #682 fixed charmcraft release rejecting resource revision 0, resolving #679. Implementation f17debfa landed via merge commit 434361d0. | |
| #253 Support for resource uploading | charmcraft | merged | Merged resource-uploading support in canonical/charmcraft#253 via commit f23482c8 and merge commit ed071757. | |
| #1287 fix(tests): fixes bundle spread test | charmcraft | merged | Merged PR #1287 (commit f60186ce, CRAFT-2052) fixed the failing bundle spread test by validating YAML with Python and dropping a non-working charm path check, resolving #1262. | |
| #1218 tests: store resources spread test is flaky | charmcraft | closed | Flaky store resources spread test was fixed by merged PR canonical/charmcraft#1223 in commit 35993996. | |
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641. | |
| #1619 fix: use charmcraft package version | charmcraft | merged | Merged PR #1619 as commit 15fac367, replacing the previous version source with the Charmcraft package version in a one-line fix. | |
| #2032 ci: fixes to several weekly spread tests | charmcraft | merged | Merged PR canonical/charmcraft#2032 as commit 29cb07f3, applying a first pass of fixes to several weekly Spread tests. | |
| #2229 style: fix linting errors | charmcraft | merged | Merged charmcraft#2229 as commit 134e1cb6, fixing lint failures from the latest Ruff and Pyright across eight files. | |
| #1540 fix: template integration tests | charmcraft | merged | Merged PR #1540 as commit f3f82031, updating integration-test templates to use charmcraft.yaml instead of metadata.yaml and completing the stalled change from #1468. |