← Back to issue list

The return code from the analyze command depends of issues found (or not).

View original Github issue

Metadata

Project
charmcraft
Number
#463
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/charmcraft#463 (implementation commit 34c31918, merge commit 1f049a14), adding configurable command return codes so analyze can reflect detected issues.

Resolution: closed resolved

Reason: Resolved by merged PR canonical/charmcraft#463, with implementation commit 34c31918 and merge commit 1f049a14. The PR explicitly added support for all commands to control return codes, including analyze based on issues found.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Note I added support for all commands to control the return code.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/charmcraft#463 (implementation commit 34c31918, merge commit 1f049a14), adding configurable command return codes so analyze can reflect detected issues.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/charmcraft#463, adding configurable command return codes so analyze can return a specific code based on detected issues.
qwen/qwen3.6-35b-a3b — — Merged implementation adding return code control to all commands. The analyze command now exits with a specific code based on issue detection. Approved by two reviewers, spanning five files.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation of configurable return codes for the analyze command based on detected issues. The change extends return code control to all commands, enabling programmatic result checking.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#462 (confidence 80%)

    The commit history shows #463 incorporated the preceding analyze JSON-output work from #462.

Related issues

Issue Project State Summary Similarity
#478 The commands that end with error should make charmcraft to return code not zero charmcraft closed Commands could report failures while exiting 0. PR #463 fixed analyze’s exit status, but no broader resolution was documented before closure.
70%