The commands that end with error should make charmcraft to return code not zero
Metadata
Current evaluation
Commands could report failures while exiting 0. PR #463 fixed analyze’s exit status, but no broader resolution was documented before closure.
Resolution: closed stale
Reason: PR #463, merged as 1f049a14 with commit 34c31918, only made analyze return nonzero when issues were found and was not recorded as resolving the broader request. No resolving change or closing rationale was documented.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Sometimes commands end with a non satisfactory resolution (e.g.: the store returning "ok=False").
Beyond showing the proper message(s) to the user (which is already happening), the command should make `charmcraft`'s retcode to NOT be 0.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Commands could report failures while exiting 0. PR #463 fixed analyze’s exit status, but no broader resolution was documented before closure. | |
| stealth/space-bunny-alpha | — | closed stale | Closed with no documented overall fix. PR #463 (commit 34c31918) made analyze return nonzero when it finds issues, but the record does not identify it as closing this broader request. | |
| stealth/space-bunny-alpha | — | closed stale | Closed without a documented resolution; no verified PR, commit, or maintainer explanation links the general non-zero-exit request to a fix. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without implementation. The request to return non-zero exit codes on command failures remains unaddressed due to prolonged inactivity. The issue was abandoned after a follow-up comment received no response. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without resolution. The request for non-zero exit codes on command errors was abandoned. No fix or pull request was merged, leaving the behavior unchanged. | |
| qwen/qwen3.6-35b-a3b | — | — | Charmcraft was requested to return non-zero exit codes on command failures. The feature request was closed without implementation, indicating it was abandoned or deferred due to inactivity. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution. No fix or pull request was merged to ensure error-ending commands return non-zero exit codes. The request remains unaddressed. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#463
(confidence 98%)
Merged configurable return codes so analyze exits nonzero when it detects issues.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #463 The return code from the analyze command depends of issues found (or not). | charmcraft | merged | Merged PR canonical/charmcraft#463 (implementation commit 34c31918, merge commit 1f049a14), adding configurable command return codes so analyze can reflect detected issues. |