parts: add entrypoint and requirements properties to charm plugin (CRAFT-393)
Metadata
Current evaluation
Merged after review. Implemented entrypoint and requirements properties for the charm plugin, deprecated matching CLI arguments, and added conflict validation. A potential regression was flagged in post-merge comments.
Suggested action: —
No scores available.
Issue body
The charm entry point and charm requirements can now be set using
charm plugin properties. Deprecation notices have been added to the
`--entrypoint` and `--requirement` command line arguments. An error is
issued if both sources of information are used at the same time.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after review. Implemented entrypoint and requirements properties for the charm plugin, deprecated matching CLI arguments, and added conflict validation. A potential regression was flagged in post-merge comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added entrypoint and requirements properties to the charm plugin, deprecating corresponding CLI arguments and enforcing mutual exclusivity. A reviewer noted a potential regression in issue #470, but the changes were integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to add entrypoint and requirements properties to the charm plugin, deprecating CLI flags and enforcing mutual exclusivity. A maintainer later flagged the change as potentially introducing a regression tracked in issue #470. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #450 parts: add charm plugin (CRAFT-89) | charmcraft | closed | Abandoned without merging. The author intended to submit a revised version to execute a charm building tool, leaving this charm plugin implementation unresolved due to pending review comments. | |
| #1808 fix(charm-plugin): remove existence checks for reqs | charmcraft | merged | Merged. Removed existence checks for requirements files in the charm plugin to prevent errors when files are not yet instantiated. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Implemented reactive plugin functionality using the charm tool, addressing CRAFT-699. Merged after approval, modifying 11 files with 499 additions and 8 deletions. |