parts: add entrypoint and requirements properties to charm plugin (CRAFT-393)
Metadata
Current evaluation
Merged as d892b3f3, adding entrypoint and requirements plugin properties, deprecating equivalent CLI flags, and rejecting dual configuration. A regression was later fixed in #472.
Resolution: closed resolved
Reason: PR #468 was merged into the main branch by commit d892b3f3, completing CRAFT-393. It introduced a requirements dependency regression tracked in #470 and fixed by follow-up PR #472 via commit 57b74577.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The charm entry point and charm requirements can now be set using
charm plugin properties. Deprecation notices have been added to the
`--entrypoint` and `--requirement` command line arguments. An error is
issued if both sources of information are used at the same time.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as d892b3f3, adding entrypoint and requirements plugin properties, deprecating equivalent CLI flags, and rejecting dual configuration. A regression was later fixed in #472. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #468 merged in d892b3f3, adding charm entrypoint/requirements properties and deprecating CLI flags; regression #470 was fixed by PR #472 (57b74577). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit d892b3f3, adding charm plugin entrypoint and requirements properties, deprecating CLI flags, and rejecting mixed sources. Regression #470 was later fixed by #472. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #468 via d892b3f3, adding charm-plugin entrypoint/requirements properties, deprecating their CLI flags, and rejecting mixed configuration. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #468 (commit d892b3f3, "parts: add entrypoint and requirements properties to charm plugin", CRAFT-393) added entrypoint/requirements charm-part properties, deprecating --entrypoint/--requirement CLI options. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged CRAFT-393: charm plugins can define entrypoint and requirements via properties; the corresponding CLI options are deprecated and cannot be combined with those properties. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after review. Implemented entrypoint and requirements properties for the charm plugin, deprecated matching CLI arguments, and added conflict validation. A potential regression was flagged in post-merge comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added entrypoint and requirements properties to the charm plugin, deprecating corresponding CLI arguments and enforcing mutual exclusivity. A reviewer noted a potential regression in issue #470, but the changes were integrated. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#470
(confidence 100%)
Reported as a regression: requirements.txt dependencies were no longer installed after #468.
-
Likely Fixed By:
charmcraft#472
(confidence 100%)
Restored dependency installation by including the charm virtual environment in the prime directory; merged as 57b74577.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #413 Charmcraft's entry point option should be in charmcraft.yaml | charmcraft | closed | Fixed in canonical/charmcraft#468 (merged as d892b3f3): charmcraft.yaml gained charm-plugin entrypoint and requirements properties for reproducible, zero-config charmcraft pack builds. | |
| #1808 fix(charm-plugin): remove existence checks for reqs | charmcraft | merged | Merged canonical/charmcraft#1808, removing charm-plugin requirements-file existence checks so initialization works before those files are created (commit 0d3b2713). |